Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1662267

[PATCH] Input: stmfts - mark all PM functions as __maybe_unused

Path csiph.com!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject [PATCH] Input: stmfts - mark all PM functions as __maybe_unused
Date Fri, 09 Jun 2017 12:40:02 +0200
Message-ID <tQpuG-nf-9@gated-at.bofh.it> (permalink)
X-Mailer git-send-email 2.9.0
X-Provags-ID V03:K0:rrrVSPIKs3w7fGU8Sp9Rw2frUDhaxaU0uZKnWAgSOJUw1rRnQWf RT/opNjBsCJxuAZ8Dpvw/U0PaDIRNnzFfc3xHY/Crq6sOk5xift2HIIZqSiZlfHHVOkk8ch Bah2/B07ntoxxmWpFyJP/AbjThbXtQhfGG7E1J5xK5Yq7a9n7flrmN3O4yvcc3DRLmpWn1R JgASOUaN9HrNDLZzVsFfg==
X-Ui-Out-Filterresults notjunk:1;V01:K0:LD8GBDHz82w=:fnN/7hKVRLGYD+UU9wuH2I orvBRuO9hvGWeO4fI4OylQiLho3NwQvCs8sa7KV7aUa7A2DTtU+t/HbLJPaABHOwwq8kkDAxF H4aWXIR4I0TRrDrMubMz72Ef/B0ObvKaZKtx5pxMjm6WOoWylVcBOKbkBYeCLKLldk8NlFXgw w0EAQ6ibTo3/JAUXunpz8Y8XJatU79r9gkNU16o88URzCJuMorv6fUe7UEA9LWex/6YB9IlRH p+eNzuoTKGu1z2DEvvHE/XCsEDAr3Ll0hH5xhpUAdboF7d8xXQCutJkPA5V/jcLeKGFCHCosf wYWelfqdWc+gGydj6mjjQsbsj+LqdiTHHf4d17vhBnk6fWYPnQ1I8HYTWeqdV/yN2ChfUwRpO tFAHLEZMC3jIHzZ/PX+7Z4nw7jh65iAWnYxEyGVPHHrBM+W7LeFAETU7vG7lxHcLvShSUPYg9 ExephPwGXkzG69yIw/wDGAmkv4ZHTtiijoSNU9OLnEQbNfjuK5xSB45RFI485JtTxI53rYKTf upLv4MAmD5RAt6vWUxzdQualm87Rqm0W212NANTo+9prmv4BwLuQmmEVmeYSNE41OHBxT/D/N Km0bFmS0IcL+xMIKRInO8g8E2ZWVauU1P76mVvyKUyyXAaBJJ9E4Iy3UHPpUZVfyEEtg3Rykc JBoKhX5OmIp2tVf1LS4tDLH1wjFp1+9XNOyigMHpdRGCelGGRwEl7EZujdCuhsPUxrIE=
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 40
Organization linux.* mail to news gateway
X-Original-Cc Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh@kernel.org>, Javier Martinez Canillas <javier@osg.samsung.com>, Andi Shyti <andi.shyti@samsung.com>, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Fri, 9 Jun 2017 12:32:48 +0200
X-Original-Message-ID <20170609103328.3130682-1-arnd@arndb.de>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1662267

Show key headers only | View raw


We get a harmless warning when CONFIG_RUNTIME_PM is disabled:

drivers/input/touchscreen/stmfts.c:760:12: error: 'stmfts_runtime_resume' defined but not used [-Werror=unused-function]
 static int stmfts_runtime_resume(struct device *dev)
drivers/input/touchscreen/stmfts.c:748:12: error: 'stmfts_runtime_suspend' defined but not used [-Werror=unused-function]
 static int stmfts_runtime_suspend(struct device *dev)

The regular PM functions are already marked as __maybe_unused, so let's
do the same for the runtime-PM as well.

Fixes: 78bcac7b2ae1 ("Input: add support for the STMicroelectronics FingerTip touchscreen")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/input/touchscreen/stmfts.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
index 802d0e82d034..157fdb4bb2e8 100644
--- a/drivers/input/touchscreen/stmfts.c
+++ b/drivers/input/touchscreen/stmfts.c
@@ -745,7 +745,7 @@ static int stmfts_remove(struct i2c_client *client)
 	return 0;
 }
 
-static int stmfts_runtime_suspend(struct device *dev)
+static int __maybe_unused stmfts_runtime_suspend(struct device *dev)
 {
 	struct stmfts_data *sdata = dev_get_drvdata(dev);
 	int ret;
@@ -757,7 +757,7 @@ static int stmfts_runtime_suspend(struct device *dev)
 	return ret;
 }
 
-static int stmfts_runtime_resume(struct device *dev)
+static int __maybe_unused stmfts_runtime_resume(struct device *dev)
 {
 	struct stmfts_data *sdata = dev_get_drvdata(dev);
 	int ret;
-- 
2.9.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH] Input: stmfts - mark all PM functions as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2017-06-09 12:40 +0200
  Re: [PATCH] Input: stmfts - mark all PM functions as __maybe_unused Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-06-09 19:00 +0200

csiph-web