Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1662257

Re: [PATCH 10/11] s390: drivers: convert to use DRIVER_ATTR_RO/WO

From Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH 10/11] s390: drivers: convert to use DRIVER_ATTR_RO/WO
Date 2017-06-09 12:30 +0200
Message-ID <tQpl0-k7-17@gated-at.bofh.it> (permalink)
References <tQo5z-84n-9@gated-at.bofh.it> <tQo5C-84n-67@gated-at.bofh.it> <tQpbj-h3-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Jun 09, 2017 at 12:11:41PM +0200, Heiko Carstens wrote:
> On Fri, Jun 09, 2017 at 11:03:13AM +0200, Greg Kroah-Hartman wrote:
> > We are trying to get rid of DRIVER_ATTR(), and the s390 drivers'
> > attributes can be trivially changed to use DRIVER_ATTR_RO() and
> > DRIVER_ATTR_WO().
> > 
> > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> > Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> > Cc: Julian Wiedmann <jwi@linux.vnet.ibm.com>
> > Cc: Ursula Braun <ubraun@linux.vnet.ibm.com>
> > Cc: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
> > Cc: Gerald Schaefer <gerald.schaefer@de.ibm.com>
> > Cc: <linux-s390@vger.kernel.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> >  drivers/s390/char/sclp.c          | 12 ++++++------
> >  drivers/s390/char/vmlogrdr.c      |  7 ++-----
> >  drivers/s390/net/ctcm_main.c      |  6 +++---
> >  drivers/s390/net/lcs.c            |  6 +++---
> >  drivers/s390/net/netiucv.c        | 14 ++++++--------
> >  drivers/s390/net/qeth_core_main.c |  6 +++---
> >  6 files changed, 23 insertions(+), 28 deletions(-)
> 
> I assume this will go upstream via your tree.

Yup, I can take it.

> Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>

Thanks for the review!

greg k-h

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 01/11] HID: hid-core: convert to use DRIVER_ATTR_RO and drv_groups Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-09 11:10 +0200
  [PATCH 02/11] IB: nes: convert to use DRIVER_ATTR_RW Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-09 11:10 +0200
    Re: [PATCH 02/11] IB: nes: convert to use DRIVER_ATTR_RW Bart Van Assche <Bart.VanAssche@sandisk.com> - 2017-06-09 17:30 +0200
  [PATCH 04/11] TTY: hvc: convert to use DRIVER_ATTR_RW Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-09 11:10 +0200
  [PATCH 10/11] s390: drivers: convert to use DRIVER_ATTR_RO/WO Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-09 11:10 +0200
    Re: [PATCH 10/11] s390: drivers: convert to use DRIVER_ATTR_RO/WO Heiko Carstens <heiko.carstens@de.ibm.com> - 2017-06-09 12:20 +0200
      Re: [PATCH 10/11] s390: drivers: convert to use DRIVER_ATTR_RO/WO Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-09 12:30 +0200
  [PATCH 11/11] USB: usbip: convert to use DRIVER_ATTR_RW Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-09 11:10 +0200
    Re: [PATCH 11/11] USB: usbip: convert to use DRIVER_ATTR_RW Shuah Khan <shuah@kernel.org> - 2017-06-09 18:00 +0200
  [PATCH 07/11] wireless: ipw2x00: convert to use DRIVER_ATTR_RW Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-09 11:10 +0200
    Re: [PATCH 07/11] wireless: ipw2x00: convert to use DRIVER_ATTR_RW Kalle Valo <kvalo@codeaurora.org> - 2017-06-09 11:30 +0200
      Re: [PATCH 07/11] wireless: ipw2x00: convert to use DRIVER_ATTR_RW Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-09 11:40 +0200
  [PATCH 03/11] PCI: pci-driver: convert to use DRIVER_ATTR_WO Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-09 11:10 +0200

csiph-web