[PATCH] mux: adg792a: always require I2C support

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH] mux: adg792a: always require I2C support
Date	2017-06-09 12:30 +0200
Message-ID	<tQpkZ-k7-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

COMPILE_TEST makes no sense when I2C is disabled, as the driver cannot compile
in that configuration:

drivers/mux/mux-adg792a.c: In function 'adg792a_write_cmd':
drivers/mux/mux-adg792a.c:34:9: error: implicit declaration of function 'i2c_smbus_write_byte_data'; did you mean 'i2c_set_clientdata'? [-Werror=implicit-function-declaration]
drivers/mux/mux-adg792a.o: In function `adg792a_driver_init':
mux-adg792a.c:(.init.text+0x14): undefined reference to `i2c_register_driver'
drivers/mux/mux-adg792a.o: In function `adg792a_probe':
mux-adg792a.c:(.text.adg792a_probe+0x94): undefined reference to `i2c_smbus_write_byte_data'
drivers/mux/mux-adg792a.o: In function `adg792a_set':
mux-adg792a.c:(.text.adg792a_set+0x80): undefined reference to `i2c_smbus_write_byte_data'

Fixes: afda08c4caa9 ("mux: adg792a: add mux controller driver for ADG792A/G")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/mux/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mux/Kconfig b/drivers/mux/Kconfig
index e8f1df74644c..7c754a0f14bb 100644
--- a/drivers/mux/Kconfig
+++ b/drivers/mux/Kconfig
@@ -19,7 +19,7 @@ if MULTIPLEXER
 
 config MUX_ADG792A
 	tristate "Analog Devices ADG792A/ADG792G Multiplexers"
-	depends on I2C || COMPILE_TEST
+	depends on I2C
 	help
 	  ADG792A and ADG792G Wide Bandwidth Triple 4:1 Multiplexers
 
-- 
2.9.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mux: adg792a: always require I2C support Arnd Bergmann <arnd@arndb.de> - 2017-06-09 12:30 +0200
  Re: [PATCH] mux: adg792a: always require I2C support Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-09 12:50 +0200

csiph-web