Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1662235

[PATCH 4/5] nvmem: core: add locking to nvmem_find_cell

Show all headers | View raw

From: Heiner Kallweit <hkallweit1@gmail.com>

Adding entries to nvmem_cells and deleting entries from it is
protected by nvmem_cells_mutex. Therefore this mutex should
also protect iterating over the list.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 drivers/nvmem/core.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 0cbac71195b5..4c49285168fb 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -287,9 +287,15 @@ static struct nvmem_cell *nvmem_find_cell(const char *cell_id)
 {
 	struct nvmem_cell *p;
 
+	mutex_lock(&nvmem_cells_mutex);
+
 	list_for_each_entry(p, &nvmem_cells, node)
-		if (p && !strcmp(p->name, cell_id))
+		if (p && !strcmp(p->name, cell_id)) {
+			mutex_unlock(&nvmem_cells_mutex);
 			return p;
+		}
+
+	mutex_unlock(&nvmem_cells_mutex);
 
 	return NULL;
 }
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] nvmem: patches or v4.13 Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-06-09 12:00 +0200
  [PATCH 1/5] nvmem: correct Broadcom OTP controller driver writes Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-06-09 12:00 +0200
  [PATCH 3/5] nvmem: core: Call put_device() in nvmem_unregister() Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-06-09 12:10 +0200
  [PATCH 5/5] nvmem: rockchip-efuse: add support for rk322x-efuse Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-06-09 12:10 +0200
  [PATCH 4/5] nvmem: core: add locking to nvmem_find_cell Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-06-09 12:10 +0200

csiph-web