Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1662230
| From | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] gpio: mvebu: fix regmap_update_bits usage |
| Date | 2017-06-09 12:10 +0200 |
| Message-ID | <tQp1E-dV-11@gated-at.bofh.it> (permalink) |
| References | <tQp1E-dV-1@gated-at.bofh.it> |
| Organization | Free Electrons |
Hello, On Fri, 9 Jun 2017 12:03:18 +0200, Gregory CLEMENT wrote: > regmap_update_bits(mvchip->regs, GPIO_IO_CONF_OFF, > - BIT(pin), 1); > + BIT(pin), BIT(pin)); > > return 0; > } > @@ -364,7 +364,7 @@ static int mvebu_gpio_direction_output(struct gpio_chip *chip, unsigned int pin, > mvebu_gpio_set(chip, pin, value); > > regmap_update_bits(mvchip->regs, GPIO_IO_CONF_OFF, > - BIT(pin), 0); > + BIT(pin), BIT(pin)); Are you sure here? We want to clear the bit, so I guess the 0 is appropriate, no? Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] gpio: mvebu: fix regmap_update_bits usage Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-06-09 12:10 +0200 Re: [PATCH] gpio: mvebu: fix regmap_update_bits usage Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-06-09 12:10 +0200 Re: [PATCH] gpio: mvebu: fix regmap_update_bits usage Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-06-09 12:10 +0200
csiph-web