Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1662043

Re: [PATCH 1/2] video: adp8860: move header file out of I2C realm

Show all headers | View raw

On Fri, 09 Jun 2017, Lee Jones wrote:

> On Mon, 22 May 2017, Wolfram Sang wrote:
> 
> > include/linux/i2c is not for client devices. Move the header file to a
> > more appropriate location.
> > 
> > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> > ---
> >  arch/blackfin/mach-bf537/boards/stamp.c        | 2 +-
> >  drivers/video/backlight/adp8860_bl.c           | 2 +-
> >  include/linux/{i2c => platform_data}/adp8860.h | 0
> >  3 files changed, 2 insertions(+), 2 deletions(-)
> >  rename include/linux/{i2c => platform_data}/adp8860.h (100%)
> 
> Applied, thanks.

Scrap that.  I can't actually apply these without Steven's Ack.

> > diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
> > index 24985e658c19cd..7db90c72bd8ddc 100644
> > --- a/arch/blackfin/mach-bf537/boards/stamp.c
> > +++ b/arch/blackfin/mach-bf537/boards/stamp.c
> > @@ -2047,7 +2047,7 @@ static struct adp8870_backlight_platform_data adp8870_pdata = {
> >  #endif
> >  
> >  #if IS_ENABLED(CONFIG_BACKLIGHT_ADP8860)
> > -#include <linux/i2c/adp8860.h>
> > +#include <linux/platform_data/adp8860.h>
> >  static struct led_info adp8860_leds[] = {
> >  	{
> >  		.name = "adp8860-led7",
> > diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
> > index 510e559c060e59..e7315bf14d6015 100644
> > --- a/drivers/video/backlight/adp8860_bl.c
> > +++ b/drivers/video/backlight/adp8860_bl.c
> > @@ -18,7 +18,7 @@
> >  #include <linux/slab.h>
> >  #include <linux/workqueue.h>
> >  
> > -#include <linux/i2c/adp8860.h>
> > +#include <linux/platform_data/adp8860.h>
> >  #define ADP8860_EXT_FEATURES
> >  #define ADP8860_USE_LEDS
> >  
> > diff --git a/include/linux/i2c/adp8860.h b/include/linux/platform_data/adp8860.h
> > similarity index 100%
> > rename from include/linux/i2c/adp8860.h
> > rename to include/linux/platform_data/adp8860.h
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] video: adp8860: move header file out of I2C realm Lee Jones <lee.jones@linaro.org> - 2017-06-09 09:50 +0200
  Re: [PATCH 1/2] video: adp8860: move header file out of I2C realm Lee Jones <lee.jones@linaro.org> - 2017-06-09 09:50 +0200

csiph-web