Re: [PATCH tip/core/rcu 45/88] rcu: Add memory barriers for NOCB leader wakeup

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Krister Johansen <kjlx@templeofstupid.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH tip/core/rcu 45/88] rcu: Add memory barriers for NOCB leader wakeup
Date	Fri, 09 Jun 2017 05:30:01 +0200
Message-ID	<tQiMx-4Eh-5@gated-at.bofh.it> (permalink)
References	<tL8Xv-5iU-1@gated-at.bofh.it> <tL97e-5CD-63@gated-at.bofh.it> <tQc4q-sN-19@gated-at.bofh.it> <tQcH7-FJ-5@gated-at.bofh.it> <tQdaa-14l-7@gated-at.bofh.it> <tQflE-2lR-5@gated-at.bofh.it>
X-Original-To	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Dkim-Signature	v=1; a=rsa-sha1; c=relaxed; d=templeofstupid.com; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=templeofstupid.com; bh=RYkxJJllKguA KzKSXwVK//n4AXU=; b=l9LbX8bLv6R0LwMwgV76XveNbfFWCn87KnlisFydaT8t F5mckphxALMvRQsFLDcZ4Fj9knW1rpEJGXX3qMFLVK6fDwjZxM+nC4yU4CJ4VPvD dacgUPog35DY4Eg/4j6NkKwIiuIB02INeSG+psFFOu+svOVaKV3YZ5ICws/Rz4w=
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	Krister Johansen <kjlx@templeofstupid.com>, linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com, stable@vger.kernel.org, gregkh@linuxfoundation.org
X-Original-Date	Thu, 8 Jun 2017 20:24:35 -0700
X-Original-Message-ID	<20170609032435.GE2553@templeofstupid.com>
X-Original-References	<20170525215934.GA11578@linux.vnet.ibm.com> <1495749601-21574-45-git-send-email-paulmck@linux.vnet.ibm.com> <20170608201148.GA2553@templeofstupid.com> <20170608205500.GC3721@linux.vnet.ibm.com> <20170608212814.GD2553@templeofstupid.com> <20170608234743.GE3721@linux.vnet.ibm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1661895

Show key headers only | View raw

On Thu, Jun 08, 2017 at 04:47:43PM -0700, Paul E. McKenney wrote:
> On Thu, Jun 08, 2017 at 02:28:14PM -0700, Krister Johansen wrote:
> > On Thu, Jun 08, 2017 at 01:55:00PM -0700, Paul E. McKenney wrote:
> > > Interesting!  This is the first that I have heard that this was anything
> > > other than a theoretical bug.  To the comment in your second URL, it is
> > > wise to recall that a seismologist was in fact arrested for failing to
> > > predict an earthquake.  Later acquitted/pardoned/whatever, but arrested
> > > nonetheless.  ;-)
> > 
> > Point taken.  I do realize that we all make mistakes, and certainly I do
> > too.
> 
> Indeed!  Let's just say that the author of that email will have no
> trouble returning the favor, and sooner rather than later.  ;-)

No doubt he's polishing up an extra small extra tight pair of handcuffs
with my name on them.

> >       Perhaps I should have said that my survey of current callers of
> > swake_up() was enough to convince me that I didn't have an immediate
> > problem elsewhere, but that I'm not familiar enough with the code base
> > to make that statement with a lot of authority.  The concern being that if
> > the patch came from RT-linux where the barrier was present in
> > swake_up(), are there other places where swake_up() callers still assume
> > this is being handled on their behalf?
> > 
> > As part of this, I also pondered whether I should add a comment around
> > swake_up(), similar to what's already there for waitqueue_active.
> > I wasn't sure how subtle this is for other consumers, though.
> 
> In my case, I assume I need barriers for swake_up(), which is why I
> found this bug by inspection.  Still, I wouldn't mind a comment.
> Others might have other opinions.

Since you don't mind, I've prepared a small patch for those comments.  I'll
send that in a separate thread.

Thanks again,

-K

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH tip/core/rcu 45/88] rcu: Add memory barriers for NOCB  leader wakeup Krister Johansen <kjlx@templeofstupid.com> - 2017-06-08 22:20 +0200
  Re: [PATCH tip/core/rcu 45/88] rcu: Add memory barriers for NOCB  leader wakeup "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-08 23:00 +0200
    Re: [PATCH tip/core/rcu 45/88] rcu: Add memory barriers for NOCB  leader wakeup Krister Johansen <kjlx@templeofstupid.com> - 2017-06-08 23:30 +0200
      Re: [PATCH tip/core/rcu 45/88] rcu: Add memory barriers for NOCB  leader wakeup "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-09 01:50 +0200
        Re: [PATCH tip/core/rcu 45/88] rcu: Add memory barriers for NOCB  leader wakeup Krister Johansen <kjlx@templeofstupid.com> - 2017-06-09 05:30 +0200

csiph-web