Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest
Date	2017-06-08 23:40 +0200
Message-ID	<tQdjP-18U-11@gated-at.bofh.it> (permalink)
References	(5 earlier) <tQbUK-nj-17@gated-at.bofh.it> <tQcQN-XZ-5@gated-at.bofh.it> <tQd0v-11f-27@gated-at.bofh.it> <tQdaa-14l-5@gated-at.bofh.it> <tQdjP-18U-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 8 Jun 2017 15:33:39 -0600
Shuah Khan <shuahkh@osg.samsung.com> wrote:

> > Note, when a bug is found, we do add the reproducer to ftracetest. So
> > depending on whether you have the latest stable, or the stable has a
> > fix, ftracetest can cause the machine to crash on older releases.  
> 
> Yeah - that could be problem, I would worry more if ftracetest can be run
> as a non-root user. As ftracetest is intrusive in nature just like the timer
> tests, we could say user needs to be aware.
> 
> If the outcome isn't desirable, we could run ftracetest conditionally as
> a last resort. I think it is important for it to be run as part of kselftest
> suite run.

Well, I wouldn't worry too much. It shouldn't do any damage. And
anything that can trigger a bug in previous kernels should be
backported as well to the stable releases. Everyone runs the latest
stable kernels, right?

Also, did you see my reply about having the right config? You have
HIST_TRIGGERS undefined but yet the histogram trigger tests all pass in
your report.

One more thing, is this 100% reproducible. That is, does it always fail?

-- Steve

Thread

Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest Shuah Khan <shuah@kernel.org> - 2017-06-08 00:50 +0200
  Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest Steven Rostedt <rostedt@goodmis.org> - 2017-06-08 01:00 +0200
    Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest Steven Rostedt <rostedt@goodmis.org> - 2017-06-08 19:40 +0200
      Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest Shuah Khan <shuahkh@osg.samsung.com> - 2017-06-08 22:10 +0200
        Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest Steven Rostedt <rostedt@goodmis.org> - 2017-06-08 23:10 +0200
          Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest Shuah Khan <shuahkh@osg.samsung.com> - 2017-06-08 23:20 +0200
            Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest Steven Rostedt <rostedt@goodmis.org> - 2017-06-08 23:30 +0200
              Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest Shuah Khan <shuahkh@osg.samsung.com> - 2017-06-08 23:40 +0200
                Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest Steven Rostedt <rostedt@goodmis.org> - 2017-06-08 23:40 +0200
                Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest Shuah Khan <shuahkh@osg.samsung.com> - 2017-06-08 23:50 +0200
                Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest Steven Rostedt <rostedt@goodmis.org> - 2017-06-09 00:00 +0200
                Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest Masami Hiramatsu <mhiramat@kernel.org> - 2017-06-14 07:00 +0200
                Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest Shuah Khan <shuah@kernel.org> - 2017-06-14 16:20 +0200
    Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest Steven Rostedt <rostedt@goodmis.org> - 2017-06-08 23:20 +0200

csiph-web