Re: [RFC PATCH 2/3] Implement sysfs based cpuinfo for x86 cpus.

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 2/3] Implement sysfs based cpuinfo for x86 cpus.
Date	2017-06-08 20:30 +0200
Message-ID	<tQalY-7K4-27@gated-at.bofh.it> (permalink)
References	<tQalY-7K4-5@gated-at.bofh.it> <tQalY-7K4-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 08, 2017 at 06:56:14PM +0200, Felix Schnizlein wrote:
> A few entries have been omitted, due to already existing information in
> sysfs:
> 
> - microcode -> /sys/devices/system/cpu/cpu*/microcode/version
> - cache -> /sys/devices/system/cpu/cpu*/cache/index*/size
> - core_id -> /sys/devices/system/cpu/cpu*/topology/core_id
> - siblings -> /sys/devices/system/cpu/cpu*/topology/core_siblings_list
> - pyshical_id -> /sys/devices/system/cpu/cpu*/topology/physical_package_id
> 
> Following attributes have been removed due to obsolete information or
> legacy processors: wp, power management, f00f bug, coma bug, fdiv bug
> 
> Signed-off-by: Thomas Renninger <trenn@suse.com>

Again, no signoff from you?

> ---
>  arch/x86/kernel/Makefile        |   1 +
>  arch/x86/kernel/cpuinfo_sysfs.c | 166 ++++++++++++++++++++++++++++++++++++++++
>  drivers/base/cpuinfo.c          |   4 -
>  3 files changed, 167 insertions(+), 4 deletions(-)
>  create mode 100644 arch/x86/kernel/cpuinfo_sysfs.c
> 

When you add new sysfs entries, you have to also add new
Documentation/ABI/ entries.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH 2/3] Implement sysfs based cpuinfo for x86 cpus. Greg KH <gregkh@linuxfoundation.org> - 2017-06-08 20:30 +0200
  Re: [RFC PATCH 2/3] Implement sysfs based cpuinfo for x86 cpus. Thomas Renninger <trenn@suse.de> - 2017-06-09 15:30 +0200
    Re: [RFC PATCH 2/3] Implement sysfs based cpuinfo for x86 cpus. Brice Goglin <Brice.Goglin@inria.fr> - 2017-06-09 17:30 +0200

csiph-web