Re: [PATCH v2 3/3] remoteproc/keystone: Ensure the DSPs are in reset in probe

From	Santosh Shilimkar <santosh.shilimkar@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/3] remoteproc/keystone: Ensure the DSPs are in reset in probe
Date	2017-06-10 21:40 +0200
Message-ID	<tQUoN-37R-1@gated-at.bofh.it> (permalink)
References	<tPTuN-5p2-5@gated-at.bofh.it> <tPTuN-5p2-13@gated-at.bofh.it>
Organization	Oracle Corporation

Show all headers | View raw

On 6/7/2017 5:24 PM, Suman Anna wrote:
> From: "Andrew F. Davis" <afd@ti.com>
> 
> The DSPs are expected to be in reset when the driver probes a device.
> If the DSPs are out of reset in probe, the system may crash when the
> firmware is being loaded. So, add a check to make sure the DSP resets
> are asserted, and if not, throw a eye-catchy warning and assert the
> resets specifically.
> 
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> [s-anna@ti.com: replace warning with a WARN]
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] Add Keystone2 Remoteproc driver Suman Anna <s-anna@ti.com> - 2017-06-08 02:30 +0200
  [PATCH v2 2/3] remoteproc/keystone: Add a remoteproc driver for Keystone 2 DSPs Suman Anna <s-anna@ti.com> - 2017-06-08 02:30 +0200
    Re: [PATCH v2 2/3] remoteproc/keystone: Add a remoteproc driver for  Keystone 2 DSPs Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2017-06-10 21:40 +0200
  [PATCH v2 1/3] dt-bindings: remoteproc: Add Keystone DSP remoteproc binding Suman Anna <s-anna@ti.com> - 2017-06-08 02:30 +0200
    Re: [PATCH v2 1/3] dt-bindings: remoteproc: Add Keystone DSP  remoteproc binding Rob Herring <robh@kernel.org> - 2017-06-09 16:30 +0200
    Re: [PATCH v2 1/3] dt-bindings: remoteproc: Add Keystone DSP  remoteproc binding Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2017-06-10 21:40 +0200
  [PATCH v2 3/3] remoteproc/keystone: Ensure the DSPs are in reset in probe Suman Anna <s-anna@ti.com> - 2017-06-08 02:30 +0200
    Re: [PATCH v2 3/3] remoteproc/keystone: Ensure the DSPs are in reset  in probe Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2017-06-10 21:40 +0200

csiph-web