Re: [PATCH] arm:lpae: build TTB control register value from scratch in v7_ttb_setup

From	Hoeun Ryu <hoeun.ryu@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] arm:lpae: build TTB control register value from scratch in v7_ttb_setup
Date	2017-06-10 06:50 +0200
Message-ID	<tQGvw-2v0-9@gated-at.bofh.it> (permalink)
References	<tPzcJ-x5-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello, Russell and Robin.

Would you please review this patch ?

Than you

> On Jun 7, 2017, at 11:39 AM, Hoeun Ryu <hoeun.ryu@gmail.com> wrote:
> 
> Reading TTBCR in early boot stage might return the value of the previous
> kernel's configuration, especially in case of kexec. For example, if
> normal kernel (first kernel) had run on a configuration of PHYS_OFFSET <=
> PAGE_OFFSET and crash kernel (second kernel) is running on a configuration
> PHYS_OFFSET > PAGE_OFFSET, which can happen because it depends on the
> reserved area for crash kernel, reading TTBCR and using the value to OR
> other bit fields might be risky because it doesn't have a reset value for
> TTBCR.
> 
> Suggested-by: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Hoeun Ryu <hoeun.ryu@gmail.com>
> ---
> 
> * v1: amended based on
>          - "[PATCHv2] arm: LPAE: kexec: clear TTBCR.T1SZ explicitly when
>             PHYS_OFFSET > PAGE_OFFSET"
>          - https://lkml.org/lkml/2017/6/5/239
> 
> arch/arm/mm/proc-v7-3level.S | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mm/proc-v7-3level.S b/arch/arm/mm/proc-v7-3level.S
> index 5e5720e..7d16bbc 100644
> --- a/arch/arm/mm/proc-v7-3level.S
> +++ b/arch/arm/mm/proc-v7-3level.S
> @@ -129,8 +129,7 @@ ENDPROC(cpu_v7_set_pte_ext)
>    .macro    v7_ttb_setup, zero, ttbr0l, ttbr0h, ttbr1, tmp
>    ldr    \tmp, =swapper_pg_dir        @ swapper_pg_dir virtual address
>    cmp    \ttbr1, \tmp, lsr #12        @ PHYS_OFFSET > PAGE_OFFSET?
> -    mrc    p15, 0, \tmp, c2, c0, 2        @ TTB control egister
> -    orr    \tmp, \tmp, #TTB_EAE
> +    mov    \tmp, #TTB_EAE            @ for TTB control egister
>    ALT_SMP(orr    \tmp, \tmp, #TTB_FLAGS_SMP)
>    ALT_UP(orr    \tmp, \tmp, #TTB_FLAGS_UP)
>    ALT_SMP(orr    \tmp, \tmp, #TTB_FLAGS_SMP << 16)
> -- 
> 2.7.4
>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] arm:lpae: build TTB control register value from scratch in v7_ttb_setup Hoeun Ryu <hoeun.ryu@gmail.com> - 2017-06-10 06:50 +0200
  Re: [PATCH] arm:lpae: build TTB control register value from scratch  in v7_ttb_setup Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-10 12:20 +0200

csiph-web