Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for bus_type

From	Stephen Rothwell <sfr@canb.auug.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for bus_type
Date	2017-06-10 02:00 +0200
Message-ID	<tQBYS-7YR-7@gated-at.bofh.it> (permalink)
References	<tPskV-4zc-3@gated-at.bofh.it> <tPskX-4zc-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Greg,

On Tue,  6 Jun 2017 21:22:20 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> -static struct device_attribute serdev_device_attrs[] = {
> -	__ATTR_RO(modalias),
> -	__ATTR_NULL
> +static struct attribute *serdev_device_attrs[] = {
                            ^^^^^^^^^^^^^^^^^^^
Should have been "serdev_device_groups"

> +	&dev_attr_modalias.attr,
> +	NULL,
>  };
> +ATTRIBUTE_GROUPS(serdev_device);
>  
>  static struct bus_type serdev_bus_type = {
>  	.name		= "serial",
> @@ -262,7 +264,7 @@ static struct bus_type serdev_bus_type = {
>  	.probe		= serdev_drv_probe,
>  	.remove		= serdev_drv_remove,
>  	.uevent		= serdev_uevent,
> -	.dev_attrs	= serdev_device_attrs,
> +	.dev_groups	= serdev_device_groups,
>  };
-- 
Cheers,
Stephen Rothwell

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for  bus_type Stephen Rothwell <sfr@canb.auug.org.au> - 2017-06-10 02:00 +0200
  Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for  bus_type Stephen Rothwell <sfr@canb.auug.org.au> - 2017-06-10 02:10 +0200
    Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for  bus_type Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-10 14:00 +0200

csiph-web