Re: [patch -mm] mm, hugetlb: schedule when potentially allocating many hugepages

From	David Rientjes <rientjes@google.com>
Newsgroups	linux.kernel
Subject	Re: [patch -mm] mm, hugetlb: schedule when potentially allocating many hugepages
Date	2017-06-10 00:40 +0200
Message-ID	<tQAJr-7ia-5@gated-at.bofh.it> (permalink)
References	<tPWVI-7FJ-9@gated-at.bofh.it> <tPXoJ-7V3-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 7 Jun 2017, Mike Kravetz wrote:

> > @@ -2364,6 +2366,7 @@ static unsigned long set_max_huge_pages(struct hstate *h, unsigned long count,
> >  			ret = alloc_fresh_gigantic_page(h, nodes_allowed);
> >  		else
> >  			ret = alloc_fresh_huge_page(h, nodes_allowed);
> > +		cond_resched();
> 
> Are not the following lines immediately before the above huge page allocation
> in set_max_huge_pages, or am I looking at an incorrect version of the file?
> 
> 		/* yield cpu to avoid soft lockup */
> 		cond_resched();

Ahh, we don't have this in our tree, thanks for catching it.  The other 
two cond_resched()'s are needed because we have reproduced them, so I'll 
send a v2.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch -mm] mm, hugetlb: schedule when potentially allocating many  hugepages David Rientjes <rientjes@google.com> - 2017-06-08 06:10 +0200
  Re: [patch -mm] mm, hugetlb: schedule when potentially allocating  many hugepages Mike Kravetz <mike.kravetz@oracle.com> - 2017-06-08 06:40 +0200
    [patch v2 -mm] mm, hugetlb: schedule when potentially allocating  many hugepages David Rientjes <rientjes@google.com> - 2017-06-10 00:40 +0200
      Re: [patch v2 -mm] mm, hugetlb: schedule when potentially allocating  many hugepages Mike Kravetz <mike.kravetz@oracle.com> - 2017-06-10 00:50 +0200
    Re: [patch -mm] mm, hugetlb: schedule when potentially allocating  many hugepages David Rientjes <rientjes@google.com> - 2017-06-10 00:40 +0200

csiph-web