Re: [PATCH] pinctrl: meson-gxl: add tsin_a pins

From	Jerome Brunet <jbrunet@baylibre.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: meson-gxl: add tsin_a pins
Date	2017-06-08 16:00 +0200
Message-ID	<tQ68G-50i-11@gated-at.bofh.it> (permalink)
References	<tQ5mi-4Gs-13@gated-at.bofh.it> <tQ68G-50i-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2017-06-08 at 15:49 +0200, Andreas Färber wrote:
> Am 08.06.2017 um 15:09 schrieb Jerome Brunet:
> > Add Tsin A pins to bank DV and X.
> > We don't have a driver for the tsin yet but since the tsin A pinmux is
> > enabled by default at boot time, declaring this pinmux is required to
> > properly operate on GPIOX.
> > 
> > Without this change, GPIOX 8, 9, 10 and 11 can't be driven as GPIO output
> > as the tsin A seems to have priority.
> 
> Should this get a Fixes header then for stable backports?

Nothing is wrong with what is already in. This is merely an addition.

If we go that way, all commit to this file should have a Fixes to the
initial commit. This seems a bit extreme to me ...

> 
> > 
> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> > ---
> >  drivers/pinctrl/meson/pinctrl-meson-gxl.c | 36
> > +++++++++++++++++++++++++++++++
> >  1 file changed, 36 insertions(+)
> 
> Looks OK AFAICT.
> 
> Cheers,
> Andreas
>

Thread

[PATCH] pinctrl: meson-gxl: add tsin_a pins Jerome Brunet <jbrunet@baylibre.com> - 2017-06-08 15:10 +0200
  Re: [PATCH] pinctrl: meson-gxl: add tsin_a pins Andreas Färber <afaerber@suse.de> - 2017-06-08 16:00 +0200
    Re: [PATCH] pinctrl: meson-gxl: add tsin_a pins Jerome Brunet <jbrunet@baylibre.com> - 2017-06-08 16:10 +0200
  Re: [PATCH] pinctrl: meson-gxl: add tsin_a pins Andreas Färber <afaerber@suse.de> - 2017-06-08 16:00 +0200
    Re: [PATCH] pinctrl: meson-gxl: add tsin_a pins Jerome Brunet <jbrunet@baylibre.com> - 2017-06-08 16:00 +0200
  Re: [PATCH] pinctrl: meson-gxl: add tsin_a pins Neil Armstrong <narmstrong@baylibre.com> - 2017-06-09 12:00 +0200
  Re: [PATCH] pinctrl: meson-gxl: add tsin_a pins Linus Walleij <linus.walleij@linaro.org> - 2017-06-16 11:20 +0200

csiph-web