Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1661161

Re: [PATCH] vfio/pci: Add Intel XXV710 to hidden INTx devices

Show all headers | View raw

[+linux-pci]

On Thu, 8 Jun 2017 01:00:17 -0700
Christoph Hellwig <hch@infradead.org> wrote:

> On Wed, Jun 07, 2017 at 01:01:46PM -0600, Alex Williamson wrote:
> > XXV710 has the same broken INTx behavior as the rest of the X/XL710
> > series, the interrupt status register is not wired to report pending
> > INTx interrupts, thus we never associate the interrupt to the device.
> > Extend the device IDs to include these so that we hide that the
> > device supports INTx at all to the user.  
> 
> Is vfio really the right place for the list?  Shouldn't this be
> keyed off the core PCI quirk for these devices?

I sent a separate patch to add these devices to the regular broken INTx
quirk in pci-core:

http://www.spinics.net/lists/linux-pci/msg61971.html

We don't currently have a device flag to specify that INTx is broken in
this particular way that vfio can work around, nor do I really know how
other drivers might make use of this info.  If I'm wrong, then
certainly let's make a common way to do this, but this patch is just a
trivial extension to an existing mechanism.  Thanks,

Alex

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] vfio/pci: Add Intel XXV710 to hidden INTx devices Alex Williamson <alex.williamson@redhat.com> - 2017-06-07 21:10 +0200
  Re: [PATCH] vfio/pci: Add Intel XXV710 to hidden INTx devices Christoph Hellwig <hch@infradead.org> - 2017-06-08 10:10 +0200
    Re: [PATCH] vfio/pci: Add Intel XXV710 to hidden INTx devices Alex Williamson <alex.williamson@redhat.com> - 2017-06-08 15:10 +0200
  Re: [PATCH] vfio/pci: Add Intel XXV710 to hidden INTx devices Jesse Brandeburg <jesse.brandeburg@intel.com> - 2017-06-08 19:20 +0200

csiph-web