Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1661080

[PATCH] Calling check_system_tsc_reliable before unsynchronized_tsc

Show all headers | View raw

unsynchronized_tsc() checks value of tsc_clocksource_reliable which is set by
check_system_tsc_reliable(). It's better to move check_system_tsc_reliable() at
front, or else this check makes no sense.

Though X86_FEATURE_CONSTANT_TSC is usually set for TSC reliable system, just in
case.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
---
  arch/x86/kernel/tsc.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 714dfba..a316bdd 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -1412,11 +1412,11 @@ void __init tsc_init(void)
  
  	use_tsc_delay();
  
+	check_system_tsc_reliable();
+
  	if (unsynchronized_tsc())
  		mark_tsc_unstable("TSCs unsynchronized");
  
-	check_system_tsc_reliable();
-
  	detect_art();
  }
  
-- 
1.7.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] Calling check_system_tsc_reliable before unsynchronized_tsc Zhenzhong Duan <zhenzhong.duan@oracle.com> - 2017-06-08 13:50 +0200
  Re: [PATCH] Calling check_system_tsc_reliable before  unsynchronized_tsc Thomas Gleixner <tglx@linutronix.de> - 2017-06-12 18:10 +0200
    Re: [PATCH] Calling check_system_tsc_reliable before  unsynchronized_tsc Zhenzhong Duan <zhenzhong.duan@oracle.com> - 2017-06-13 04:50 +0200

csiph-web