Re: [PATCH V1 11/15] spmi: spmi-pmic-arb: enable the SPMI interrupt as a wakeup source

From	kgunda@codeaurora.org
Newsgroups	linux.kernel
Subject	Re: [PATCH V1 11/15] spmi: spmi-pmic-arb: enable the SPMI interrupt as a wakeup source
Date	2017-06-08 13:40 +0200
Message-ID	<tQ3Xb-3Gr-5@gated-at.bofh.it> (permalink)
References	<tMOKZ-7oW-9@gated-at.bofh.it> <tMOL0-7oW-17@gated-at.bofh.it> <tNfrR-7Ij-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2017-05-31 22:43, Stephen Boyd wrote:
> On 05/30, Kiran Gunda wrote:
>> Currently the SPMI interrupt will not wake the device. Enable this
>> interrupt as a wakeup source.
>> 
>> Signed-off-by: Nicholas Troast <ntroast@codeaurora.org>
>> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> ---
>>  drivers/spmi/spmi-pmic-arb.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/spmi/spmi-pmic-arb.c 
>> b/drivers/spmi/spmi-pmic-arb.c
>> index 0deac33..2afe359 100644
>> --- a/drivers/spmi/spmi-pmic-arb.c
>> +++ b/drivers/spmi/spmi-pmic-arb.c
>> @@ -1140,6 +1140,7 @@ static int spmi_pmic_arb_probe(struct 
>> platform_device *pdev)
>>  	}
>> 
>>  	irq_set_chained_handler_and_data(pa->irq, pmic_arb_chained_irq, pa);
>> +	enable_irq_wake(pa->irq);
> 
> Why don't we do this through an irq_set_wake callback in the
> irqchip? That way, we don't mark this irq as wakeup if any child
> irqs aren't marked as wakeup.
Yes. This looks cleaner. Will change it in the subsequent patch.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH V1 11/15] spmi: spmi-pmic-arb: enable the SPMI interrupt  as a wakeup source kgunda@codeaurora.org - 2017-06-08 13:40 +0200

csiph-web