Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1661000

Re: [PATCH] cpu/hotplug: remove unused check_for_tasks() function

Show all headers | View raw

On 2017-06-08 10:55:33 [+0200], Arnd Bergmann wrote:
> clang -Wunused-function found one remaining function that was
> apparently meant to be removed in a recent code cleanup:
> 
> kernel/cpu.c:565:20: warning: unused function 'check_for_tasks' [-Wunused-function]

Oh, so we lost the check while we were removing the DEAD notifier. The
teardown part of CPUHP_AP_SCHED_STARTING (which came before that check)
does migrate_tasks() => select_fallback_rq() for each task on the CPU
and will BUG() if it can't move a task away (except for kernel threads).
So I think it should be safe remove that function.
 
> Fixes: 530e9b76ae8f ("cpu/hotplug: Remove obsolete cpu hotplug register/unregister functions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] cpu/hotplug: remove unused check_for_tasks() function Arnd Bergmann <arnd@arndb.de> - 2017-06-08 11:00 +0200
  Re: [PATCH] cpu/hotplug: remove unused check_for_tasks() function Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2017-06-08 11:50 +0200
  [tip:smp/hotplug] cpu/hotplug: Remove unused check_for_tasks()  function tip-bot for Arnd Bergmann <tipbot@zytor.com> - 2017-06-12 19:10 +0200

csiph-web