Re: [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler

From	Christoph Hellwig <hch@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler
Date	2017-06-08 09:40 +0200
Message-ID	<tQ0cX-1hd-59@gated-at.bofh.it> (permalink)
References	<tNctY-5S4-19@gated-at.bofh.it> <tNcu0-5S4-51@gated-at.bofh.it> <tNr9D-6Ua-5@gated-at.bofh.it> <tNvPY-1sb-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi John,

sorry for dropping the ball, but your repost reminded me.

On Thu, Jun 01, 2017 at 11:36:55AM +0100, John Garry wrote:
> In the command completion code we need to check for abnormal completion due
> to underflow, but ignore it when it occurs in some commands, like inquiry.
> This is why we check for rw command - it is equivalent to !inquiry.
> 
> I'll see if we can change the check to explicitly ignore certain commands
> which complete abnormally with underflow.

In general it should be up to the higher level and not the driver
to detect underflow, and that's how most (hopefully all, but I won't
bet on some older ones) of our drivers operate.

> 
> > What about 32-byte CDs or things like Write Same?
> > 
> 
> You're talking about VARIABLE_LENGTH_CMD (opcode 0x7f) for 32-byte CDs,
> right?

Yes.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler Christoph Hellwig <hch@infradead.org> - 2017-06-08 09:40 +0200
  Re: [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler John Garry <john.garry@huawei.com> - 2017-06-08 14:20 +0200

csiph-web