Re: [PATCH] mm: vmscan: do not pass reclaimed slab to vmpressure

From	Minchan Kim <minchan@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: vmscan: do not pass reclaimed slab to vmpressure
Date	2017-06-07 05:10 +0200
Message-ID	<tPzw5-TK-3@gated-at.bofh.it> (permalink)
References	(2 earlier) <t3KNb-3lW-1@gated-at.bofh.it> <t3T46-8qV-15@gated-at.bofh.it> <t49Vg-1J9-11@gated-at.bofh.it> <t5tRT-1Nt-5@gated-at.bofh.it> <tPmpd-OH-57@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On Tue, Jun 06, 2017 at 09:00:55PM +0800, zhong jiang wrote:
> On 2017/1/31 7:40, Minchan Kim wrote:
> > Hi Vinayak,
> > Sorry for late response. It was Lunar New Year holidays.
> >
> > On Fri, Jan 27, 2017 at 01:43:23PM +0530, vinayak menon wrote:
> >>> Thanks for the explain. However, such case can happen with THP page
> >>> as well as slab. In case of THP page, nr_scanned is 1 but nr_reclaimed
> >>> could be 512 so I think vmpressure should have a logic to prevent undeflow
> >>> regardless of slab shrinking.
> >>>
> >> I see. Going to send a vmpressure fix. But, wouldn't the THP case
> >> result in incorrect
> >> vmpressure reporting even if we fix the vmpressure underflow problem ?
> > If a THP page is reclaimed, it reports lower pressure due to bigger
> > reclaim ratio(ie, reclaimed/scanned) compared to normal pages but
> > it's not a problem, is it? Because VM reclaimed more memory than
> > expected so memory pressure isn't severe now.
>   Hi, Minchan
> 
>   THP lru page is reclaimed, reclaim ratio bigger make sense. but I read the code, I found
>   THP is split to normal pages and loop again.  reclaimed pages should not be bigger
>    than nr_scan.  because of each loop will increase nr_scan counter.
>  
>    It is likely  I miss something.  you can point out the point please.

You are absolutely right.

I got confused by nr_scanned from isolate_lru_pages and sc->nr_scanned
from shrink_page_list.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mm: vmscan: do not pass reclaimed slab to vmpressure zhong jiang <zhongjiang@huawei.com> - 2017-06-06 15:10 +0200
  Re: [PATCH] mm: vmscan: do not pass reclaimed slab to vmpressure zhong jiang <zhongjiang@huawei.com> - 2017-06-07 05:10 +0200
  Re: [PATCH] mm: vmscan: do not pass reclaimed slab to vmpressure Minchan Kim <minchan@kernel.org> - 2017-06-07 05:10 +0200

csiph-web