Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1659182

Re: [PATCH v4] net: don't call strlen on non-terminated string in dev_set_alias()

Show all headers | View raw

From: Alexander Potapenko <glider@google.com>
Date: Tue,  6 Jun 2017 15:56:54 +0200

> KMSAN reported a use of uninitialized memory in dev_set_alias(),
> which was caused by calling strlcpy() (which in turn called strlen())
> on the user-supplied non-terminated string.
> 
> Signed-off-by: Alexander Potapenko <glider@google.com>

We should not be allowing non-NULL terminated strings for the
IFLA_IFALIAS attribute.  It's defined as type NLA_STRING in
the ifla_policy[] array.

Please figure out why we aren't enforcing the attribute policy
properly, rather than adding a workaround.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4] net: don't call strlen on non-terminated string in dev_set_alias() Alexander Potapenko <glider@google.com> - 2017-06-06 16:30 +0200
  Re: [PATCH v4] net: don't call strlen on non-terminated string in  dev_set_alias() David Miller <davem@davemloft.net> - 2017-06-06 22:40 +0200
    Re: [PATCH v4] net: don't call strlen on non-terminated string in dev_set_alias() Alexander Potapenko <glider@google.com> - 2017-06-06 23:20 +0200
    Re: [PATCH v4] net: don't call strlen on non-terminated string in  dev_set_alias() Florian Westphal <fw@strlen.de> - 2017-06-07 00:00 +0200
      Re: [PATCH v4] net: don't call strlen on non-terminated string in  dev_set_alias() David Miller <davem@davemloft.net> - 2017-06-07 03:10 +0200

csiph-web