Re: [PATCH net] net: stmmac: fix completely hung TX when using TSO

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net] net: stmmac: fix completely hung TX when using TSO
Date	2017-06-06 22:30 +0200
Message-ID	<tPth0-5bW-9@gated-at.bofh.it> (permalink)
References	<tPh6a-5ES-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Niklas Cassel <niklas.cassel@axis.com>
Date: Tue, 6 Jun 2017 09:25:00 +0200

> stmmac_tso_allocator can fail to set the Last Descriptor bit
> on a descriptor that actually was the last descriptor.
> 
> This happens when the buffer of the last descriptor ends
> up having a size of exactly TSO_MAX_BUFF_SIZE.
> 
> When the IP eventually reaches the next last descriptor,
> which actually has the bit set, the DMA will hang.
> 
> When the DMA hangs, we get a tx timeout, however,
> since stmmac does not do a complete reset of the IP
> in stmmac_tx_timeout, we end up in a state with
> completely hung TX.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>

Applied and queued up for -stable, thank you.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net] net: stmmac: fix completely hung TX when using TSO Niklas Cassel <niklas.cassel@axis.com> - 2017-06-06 09:30 +0200
  Re: [PATCH net] net: stmmac: fix completely hung TX when using TSO Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2017-06-06 10:10 +0200
    Re: [PATCH net] net: stmmac: fix completely hung TX when using TSO Alexandre Torgue <alexandre.torgue@st.com> - 2017-06-06 11:20 +0200
    Re: [PATCH net] net: stmmac: fix completely hung TX when using TSO Niklas Cassel <niklas.cassel@axis.com> - 2017-06-06 12:10 +0200
  Re: [PATCH net] net: stmmac: fix completely hung TX when using TSO Florian Fainelli <f.fainelli@gmail.com> - 2017-06-06 16:40 +0200
  Re: [PATCH net] net: stmmac: fix completely hung TX when using TSO David Miller <davem@davemloft.net> - 2017-06-06 22:30 +0200

csiph-web