Re: [PATCH][V2] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH][V2] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value
Date	2017-06-06 21:20 +0200
Message-ID	<tPsbh-4vm-67@gated-at.bofh.it> (permalink)
References	<tOWbp-Zl-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin King <colin.king@canonical.com>
Date: Mon,  5 Jun 2017 10:04:52 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> The current comparison of entry < 0 will never be true since entry is an
> unsigned integer. Make entry an int to ensure -ve error return values
> from the call to jumbo_frm are correctly being caught.
> 
> Detected by CoverityScan, CID#1238760 ("Macro compares unsigned to 0")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

I know Julia asked for more comments, but I'm going to apply this
as-is for now as it is correct.

Thanks Colin.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH][V2] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value Colin King <colin.king@canonical.com> - 2017-06-05 11:10 +0200
  Re: [PATCH][V2] net: stmmac: ensure jumbo_frm error return is  correctly checked for -ve value Julia Lawall <julia.lawall@lip6.fr> - 2017-06-05 11:30 +0200
  Re: [PATCH][V2] net: stmmac: ensure jumbo_frm error return is  correctly checked for -ve value David Miller <davem@davemloft.net> - 2017-06-06 21:20 +0200

csiph-web