Re: [PATCH 0/4][V3] Improve watchdog config for arch watchdogs

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Don Zickus <dzickus@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/4][V3] Improve watchdog config for arch watchdogs
Date	Tue, 06 Jun 2017 18:10:01 +0200
Message-ID	<tPpdn-2Df-7@gated-at.bofh.it> (permalink)
References	<tME8V-8vo-3@gated-at.bofh.it>
X-Original-To	Nicholas Piggin <npiggin@gmail.com>, babu.moger@oracle.com
Dmarc-Filter	OpenDMARC Filter v1.3.2 mx1.redhat.com 9876C34A6
Authentication-Results	ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results	ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dzickus@redhat.com
Dkim-Filter	OpenDKIM Filter v2.11.0 mx1.redhat.com 9876C34A6
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	NeoMutt/20170428-dirty (1.8.2)
X-Scanned-By	MIMEDefang 2.79 on 10.5.11.11
X-Greylist	Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 06 Jun 2017 16:08:48 +0000 (UTC)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	52
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
X-Original-Date	Tue, 6 Jun 2017 12:08:47 -0400
X-Original-Message-ID	<20170606160847.izishwer3m5jirkb@redhat.com>
X-Original-References	<20170530012659.16791-1-npiggin@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1658890

Show key headers only | View raw

(adding Babu)

On Tue, May 30, 2017 at 11:26:55AM +1000, Nicholas Piggin wrote:
> Since last time:
> 
> - Have the perf based hardlockup detector use arch_touch_nmi_watchdog()
>   rather than hld_touch_nmi_watchdog(). This changes direction slightly
>   to make the perf-based hard lockup detector an alternative that an
>   arch may select, rather than standalone. This better reflects how the
>   code works in practice).
> 
> - Hopefully fixed the Kconfig options. There's still a bit of ugliness
>   that will require another pass or two over interfaces and config
>   scheme, but the idea is to make a minimal change to get the powerpc
>   HLD in, which gives a reasonable starting point to improve things
>   further.

Hi Babu,

Does this patchset break sparc?  Specifically patch3 with all the config
option changes?

Cheers,
Don

> 
> Nicholas Piggin (4):
>   watchdog: remove unused declaration
>   watchdog: Introduce arch_touch_nmi_watchdog()
>   watchdog: Split up config options
>   watchdog: Provide watchdog_reconfigure() for arch watchdogs
> 
>  arch/blackfin/include/asm/nmi.h            |   2 +
>  arch/blackfin/kernel/nmi.c                 |   2 +-
>  arch/mn10300/include/asm/nmi.h             |   2 +
>  arch/mn10300/kernel/mn10300-watchdog-low.S |   8 +-
>  arch/mn10300/kernel/mn10300-watchdog.c     |   2 +-
>  arch/powerpc/kernel/setup_64.c             |   2 +-
>  arch/sparc/include/asm/nmi.h               |   1 +
>  arch/sparc/kernel/nmi.c                    |   6 +-
>  arch/x86/kernel/apic/hw_nmi.c              |   2 +-
>  include/linux/nmi.h                        |  57 ++++---
>  kernel/Makefile                            |   2 +-
>  kernel/sysctl.c                            |  18 +-
>  kernel/watchdog.c                          | 263 +++++++++++++++++++----------
>  kernel/watchdog_hld.c                      |  37 +---
>  lib/Kconfig.debug                          |  29 +++-
>  15 files changed, 263 insertions(+), 170 deletions(-)
> 
> -- 
> 2.11.0
>

Thread

[PATCH 0/4][V3] Improve watchdog config for arch watchdogs Nicholas Piggin <npiggin@gmail.com> - 2017-05-30 03:30 +0200
  [PATCH 1/4] watchdog: remove unused declaration Nicholas Piggin <npiggin@gmail.com> - 2017-05-30 03:30 +0200
  [PATCH 2/4] watchdog: Introduce arch_touch_nmi_watchdog() Nicholas Piggin <npiggin@gmail.com> - 2017-05-30 03:30 +0200
  [PATCH 4/4] watchdog: Provide watchdog_reconfigure() for arch watchdogs Nicholas Piggin <npiggin@gmail.com> - 2017-05-30 03:30 +0200
  Re: [PATCH 0/4][V3] Improve watchdog config for arch watchdogs Don Zickus <dzickus@redhat.com> - 2017-06-06 18:10 +0200
    Re: [PATCH 0/4][V3] Improve watchdog config for arch watchdogs Babu Moger <babu.moger@oracle.com> - 2017-06-06 21:50 +0200
      Re: [PATCH 0/4][V3] Improve watchdog config for arch watchdogs Don Zickus <dzickus@redhat.com> - 2017-06-07 16:40 +0200

csiph-web