Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1658850

Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

From Enric Balletbo Serra <eballetbo@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF
Date 2017-06-06 17:10 +0200
Message-ID <tPohj-20d-1@gated-at.bofh.it> (permalink)
References <tPnXY-1DX-3@gated-at.bofh.it> <tPnXY-1DX-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Keerthy,

By change I was looking at this. Some comments below that I think can
be applied to all patches in this series

2017-06-06 16:45 GMT+02:00 Keerthy <j-keerthy@ti.com>:
> Currently the driver boots only via device tree hence add a
> dependency on OF.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  drivers/mfd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 75b59f1..2d1425d 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1297,7 +1297,7 @@ config MFD_TPS65090
>
>  config MFD_TPS65217
>         tristate "TI TPS65217 Power Management / White LED chips"
> -       depends on I2C
> +       depends on I2C && OF

Shouldn't you add || COMPILE_TEST here ?

>         select MFD_CORE
>         select REGMAP_I2C
>         select IRQ_DOMAIN
> --
> 1.9.1
>

I think you can remove the of_match_device checks in some drivers too

i.e:

http://elixir.free-electrons.com/linux/latest/source/drivers/mfd/tps65217.c#L330

Regards,
 Enric

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] mfd: Add a dependency on OF Keerthy <j-keerthy@ti.com> - 2017-06-06 16:50 +0200
  [PATCH 5/5] mfd: lp3943: Add a dependency on OF Keerthy <j-keerthy@ti.com> - 2017-06-06 16:50 +0200
  [PATCH 3/5] mfd: tps65217: Add a dependency on OF Keerthy <j-keerthy@ti.com> - 2017-06-06 16:50 +0200
    Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF Enric Balletbo Serra <eballetbo@gmail.com> - 2017-06-06 17:10 +0200
      Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF Keerthy <j-keerthy@ti.com> - 2017-06-07 06:50 +0200
        Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF Keerthy <j-keerthy@ti.com> - 2017-06-07 12:40 +0200
        Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF Lee Jones <lee.jones@linaro.org> - 2017-06-07 12:40 +0200
          Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF Keerthy <j-keerthy@ti.com> - 2017-06-07 13:30 +0200
            Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF Enric Balletbo Serra <eballetbo@gmail.com> - 2017-06-07 15:40 +0200
              Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF Keerthy <j-keerthy@ti.com> - 2017-06-07 15:50 +0200
                Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF Javier Martinez Canillas <javier@dowhile0.org> - 2017-06-07 16:20 +0200
                Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF Javier Martinez Canillas <javier@dowhile0.org> - 2017-06-07 16:30 +0200
        Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF Lee Jones <lee.jones@linaro.org> - 2017-06-07 12:40 +0200
  [PATCH 4/5] mfd: lp873x: Add a dependency on OF Keerthy <j-keerthy@ti.com> - 2017-06-06 16:50 +0200
  [PATCH 1/5] mfd: palmas: Add a dependency on OF Keerthy <j-keerthy@ti.com> - 2017-06-06 16:50 +0200

csiph-web