Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1658784

Re: [PATCH v4 2/8] mfd: hi6421-pmic: cleanup: update dev_err messages

Show all headers | View raw

On Tue, 06 Jun 2017, Guodong Xu wrote:

> Update dev_err messages to make them more readable.
> 
> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
> ---
>  drivers/mfd/hi6421-pmic-core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
  
> diff --git a/drivers/mfd/hi6421-pmic-core.c b/drivers/mfd/hi6421-pmic-core.c
> index ad9e3d8..b1139d4 100644
> --- a/drivers/mfd/hi6421-pmic-core.c
> +++ b/drivers/mfd/hi6421-pmic-core.c
> @@ -52,8 +52,8 @@ static int hi6421_pmic_probe(struct platform_device *pdev)
>  	pmic->regmap = devm_regmap_init_mmio_clk(&pdev->dev, NULL, base,
>  						 &hi6421_regmap_config);
>  	if (IS_ERR(pmic->regmap)) {
> -		dev_err(&pdev->dev,
> -			"regmap init failed: %ld\n", PTR_ERR(pmic->regmap));
> +		dev_err(&pdev->dev, "Failed to initialise Regmap: %ld\n",
> +						PTR_ERR(pmic->regmap));
>  		return PTR_ERR(pmic->regmap);
>  	}
>  
> @@ -70,7 +70,7 @@ static int hi6421_pmic_probe(struct platform_device *pdev)
>  	ret = devm_mfd_add_devices(&pdev->dev, 0, hi6421_devs,
>  				   ARRAY_SIZE(hi6421_devs), NULL, 0, NULL);
>  	if (ret) {
> -		dev_err(&pdev->dev, "add mfd devices failed: %d\n", ret);
> +		dev_err(&pdev->dev, "Failed to add child devices: %d\n", ret);
>  		return ret;
>  	}
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/8] MFD: add driver for HiSilicon Hi6421v530 PMIC Guodong Xu <guodong.xu@linaro.org> - 2017-06-06 11:00 +0200
  [PATCH v4 8/8] arm64: defconfig: enable support hi6421v530 PMIC Guodong Xu <guodong.xu@linaro.org> - 2017-06-06 11:00 +0200
  [PATCH v4 5/8] regulator: hi6421v530: add driver for hi6421v530 voltage regulator Guodong Xu <guodong.xu@linaro.org> - 2017-06-06 11:00 +0200
  [PATCH v4 2/8] mfd: hi6421-pmic: cleanup: update dev_err messages Guodong Xu <guodong.xu@linaro.org> - 2017-06-06 11:00 +0200
    Re: [PATCH v4 2/8] mfd: hi6421-pmic: cleanup: update dev_err messages Lee Jones <lee.jones@linaro.org> - 2017-06-06 16:00 +0200
  [PATCH v4 6/8] regulator: hi6421: Describe consumed platform device Guodong Xu <guodong.xu@linaro.org> - 2017-06-06 11:00 +0200
  [PATCH v4 1/8] mfd: hi6421-pmic: cleanup: change license text to shorter form Guodong Xu <guodong.xu@linaro.org> - 2017-06-06 11:00 +0200
    Re: [PATCH v4 1/8] mfd: hi6421-pmic: cleanup: change license text to  shorter form Lee Jones <lee.jones@linaro.org> - 2017-06-06 16:00 +0200
  [PATCH v4 3/8] dt-bindings: mfd: hi6421: Add hi6421v530 compatible string Guodong Xu <guodong.xu@linaro.org> - 2017-06-06 11:00 +0200
  [PATCH v4 4/8] mfd: hi6421-pmic: add support for HiSilicon Hi6421v530 Guodong Xu <guodong.xu@linaro.org> - 2017-06-06 11:00 +0200
    Re: [PATCH v4 4/8] mfd: hi6421-pmic: add support for HiSilicon  Hi6421v530 Lee Jones <lee.jones@linaro.org> - 2017-06-06 16:00 +0200
      Re: [PATCH v4 4/8] mfd: hi6421-pmic: add support for HiSilicon Hi6421v530 Guodong Xu <guodong.xu@linaro.org> - 2017-06-07 09:10 +0200
  [PATCH v4 7/8] arm64: dts: hikey960: add device node for pmic and regulators Guodong Xu <guodong.xu@linaro.org> - 2017-06-06 11:00 +0200
  Re: [PATCH v4 0/8] MFD: add driver for HiSilicon Hi6421v530 PMIC Arnd Bergmann <arnd@arndb.de> - 2017-06-06 15:00 +0200
    Re: [PATCH v4 0/8] MFD: add driver for HiSilicon Hi6421v530 PMIC Lee Jones <lee.jones@linaro.org> - 2017-06-06 16:00 +0200
      Re: [PATCH v4 0/8] MFD: add driver for HiSilicon Hi6421v530 PMIC Arnd Bergmann <arnd@arndb.de> - 2017-06-07 09:20 +0200

csiph-web