Re: [PATCH][REGRESSION] drm: kirin: Fix drm_of_find_panel_or_bridge conversion

From	Sean Paul <seanpaul@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH][REGRESSION] drm: kirin: Fix drm_of_find_panel_or_bridge conversion
Date	2017-06-06 16:40 +0200
Message-ID	<tPnOi-1Aw-23@gated-at.bofh.it> (permalink)
References	<tKlap-5Kr-3@gated-at.bofh.it> <tNZbk-4Ci-21@gated-at.bofh.it> <tNZbk-4Ci-19@gated-at.bofh.it> <tNZXH-4Tg-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 2, 2017 at 2:52 PM, Sean Paul <seanpaul@chromium.org> wrote:
> On Fri, Jun 2, 2017 at 2:00 PM, John Stultz <john.stultz@linaro.org> wrote:
>> On Tue, May 23, 2017 at 8:04 PM, Xinliang Liu <xinliang.liu@linaro.org> wrote:
>>> On 24 May 2017 at 00:40, John Stultz <john.stultz@linaro.org> wrote:
>>>>
>>>> This fixes a regression introduced by ebc944613567 ("drm:
>>>> convert drivers to use drm_of_find_panel_or_bridge") that was
>>>> recently merged, causing HDMI output to not work.
>>>>
>>>> For the kirin driver, the port value should be 1 instead of 0,
>>>> so this oneline patch fixes it and gets graphics working again.
>>>>
>>>> Cc: Rob Herring <robh@kernel.org>
>>>> Cc: Archit Taneja <architt@codeaurora.org>
>>>> Cc: Philipp Zabel <p.zabel@pengutronix.de>
>>>> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
>>>> Cc: Sean Paul <seanpaul@chromium.org>
>>>> Cc: Dave Airlie <airlied@gmail.com>
>>>> Cc:
>>>> Xinliang Liu <xinliang.liu@linaro.org>
>>>> Fix-suggested-by: Rob Herring <robh@kernel.org>
>>>> Signed-off-by: John Stultz <john.stultz@linaro.org>
>>>
>>>
>>> Looks good to me. Thanks for the patch.
>>>
>>> Reviewed-by:
>>> Xinliang Liu <xinliang.liu@linaro.org>
>>>
>>
>> Just wanted to check in on this. Is there someone I'm missing from the
>> cc list on this?
>>
>
> Hi John,
> Apologies, I just saw this. Slipped through my cracks because it's not
> posted on dri-devel.
>
> The patch looks good. I'll pick it up in drm-misc-fixes if Dave
> doesn't take it directly into drm-fixes.
>

Hi John,
I've picked this up in drm-misc-fixes.

Thanks again for the patch,

Sean



> Sean
>
>
>> thanks
>> -john

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH][REGRESSION] drm: kirin: Fix drm_of_find_panel_or_bridge conversion John Stultz <john.stultz@linaro.org> - 2017-06-02 20:10 +0200
  Re: [PATCH][REGRESSION] drm: kirin: Fix drm_of_find_panel_or_bridge conversion Sean Paul <seanpaul@chromium.org> - 2017-06-02 21:00 +0200
    Re: [PATCH][REGRESSION] drm: kirin: Fix drm_of_find_panel_or_bridge conversion Sean Paul <seanpaul@chromium.org> - 2017-06-06 16:40 +0200

csiph-web