Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

From	Corentin Labbe <clabbe.montjoie@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request
Date	2017-06-06 16:30 +0200
Message-ID	<tPnEC-1x7-15@gated-at.bofh.it> (permalink)
References	<tPn1U-12m-17@gated-at.bofh.it> <tPn1V-12m-25@gated-at.bofh.it> <tPnuW-1tS-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 06, 2017 at 04:07:25PM +0200, Stephan Müller wrote:
> Am Dienstag, 6. Juni 2017, 15:44:17 CEST schrieb Corentin Labbe:
> 
> Hi Corentin,
> 
> > The crypto engine could actually only enqueue hash and ablkcipher request.
> > This patch permit it to enqueue skcipher requets by adding all necessary
> > functions.
> > The only problem is that ablkcipher and skcipher id are the same, so
> > only one cipher type is usable on the same crypto engine.
> 
> Why do you think this is needed? I thought that skcipher is the successor to 
> ablkcipher AND blkcipher. I.e. ablkcipher and blkcipher should be phased out. 
> Thus, I would infer that any ablkcipher support should or could be dropped.
> 

There are two user of it, crypto/omap and crypto/virtio.
And for crypto/omap, I have no way of testing any convertion to skcipher (no hardware).

Regards
Corentin Labbe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] crypto: engine - Permit to enqueue skcipher request Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-06-06 15:50 +0200
  [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-06-06 15:50 +0200
    Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request Stephan Müller <smueller@chronox.de> - 2017-06-06 16:20 +0200
      Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher  request Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-06-06 16:30 +0200

csiph-web