Re: [PATCH v4 1/2] tty: add compat_ioctl callbacks

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/2] tty: add compat_ioctl callbacks
Date	2017-06-06 14:50 +0200
Message-ID	<tPm5Q-qi-5@gated-at.bofh.it> (permalink)
References	<tOi4h-850-5@gated-at.bofh.it> <tOi4h-850-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jun 3, 2017 at 4:15 PM, Aleksa Sarai <asarai@suse.de> wrote:
> In order to avoid future diversions between fs/compat_ioctl.c and
> drivers/tty/pty.c, define .compat_ioctl callbacks for the relevant
> tty_operations structs. Since both pty_unix98_ioctl() and
> pty_bsd_ioctl() are compatible between 32-bit and 64-bit userspace no
> special translation is required.
>
> Signed-off-by: Aleksa Sarai <asarai@suse.de>

Looks good,

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 1/2] tty: add compat_ioctl callbacks Aleksa Sarai <asarai@suse.de> - 2017-06-03 16:20 +0200
  Re: [PATCH v4 1/2] tty: add compat_ioctl callbacks Arnd Bergmann <arnd@arndb.de> - 2017-06-06 14:50 +0200

csiph-web