Re: [PATCH v7 09/26] x86/insn-eval: Add utility function to identify string instructions

From	Borislav Petkov <bp@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 09/26] x86/insn-eval: Add utility function to identify string instructions
Date	2017-06-06 14:10 +0200
Message-ID	<tPlt8-aF-19@gated-at.bofh.it> (permalink)
References	<tDPZD-5j6-3@gated-at.bofh.it> <tDQ9k-5mF-15@gated-at.bofh.it> <tMAI2-5XO-7@gated-at.bofh.it> <tPfQL-4Zi-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 05, 2017 at 11:01:21PM -0700, Ricardo Neri wrote:
> If I was to leave out string instructions from this function it should
> be renamed as is_string_instruction_non_lods_outs. In my opinion this
> separation makes the code more clear and I would end up having logic to
> decide which segment register to use in two places. Does it makes sense
> to you?

Ok, sure.

Thanks.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v7 09/26] x86/insn-eval: Add utility function to identify  string instructions Borislav Petkov <bp@suse.de> - 2017-05-29 23:50 +0200
  Re: [PATCH v7 09/26] x86/insn-eval: Add utility function to  identify string instructions Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2017-06-06 08:10 +0200
    Re: [PATCH v7 09/26] x86/insn-eval: Add utility function to identify  string instructions Borislav Petkov <bp@suse.de> - 2017-06-06 14:10 +0200

csiph-web