Re: [PATCH] tty: ipwireless: fix potential NULL pointer dereference

From	David Sterba <dsterba@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tty: ipwireless: fix potential NULL pointer dereference
Date	2017-06-06 12:50 +0200
Message-ID	<tPkdI-7xX-15@gated-at.bofh.it> (permalink)
References	<tP7gt-7Lh-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 05, 2017 at 03:50:02PM -0500, Gustavo A. R. Silva wrote:
> Add null check before dereferencing pointer ver_packet.
> Print error message and exit in case pointer ver_packet
> is NULL.

And what next? The caller does not expect a failure and continues as if
the packet has been set up and sent and waiting for a response. This
will likely hang somewhere or just do nothing regarding
sending/receiving user packets. Failures of alloc_ctrl_packet are
handled elsewhere, even during the setup phase so this could be handled
more gracefully.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tty: ipwireless: fix potential NULL pointer dereference "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-05 23:00 +0200
  Re: [PATCH] tty: ipwireless: fix potential NULL pointer dereference David Sterba <dsterba@suse.cz> - 2017-06-06 12:50 +0200

csiph-web