Re: [PATCH V1 14/15] spmi: pmic-arb: do not ack and clear peripheral interrupts in cleanup_irq

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	kgunda@codeaurora.org
Newsgroups	linux.kernel
Subject	Re: [PATCH V1 14/15] spmi: pmic-arb: do not ack and clear peripheral interrupts in cleanup_irq
Date	Tue, 06 Jun 2017 13:30:02 +0200
Message-ID	<tPkQp-89v-19@gated-at.bofh.it> (permalink)
References	<tMOKZ-7oW-9@gated-at.bofh.it> <tMOL0-7oW-27@gated-at.bofh.it> <tNg4x-7XU-11@gated-at.bofh.it> <tNPbY-6hW-9@gated-at.bofh.it>
X-Original-To	Stephen Boyd <sboyd@codeaurora.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1496748461; bh=5E92Orz+dwEcqGycZWz66OjMMBA6TzUfKrbps29ZKyU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cbsQJpvcJZBs6yihMCbmoh9vmqkovZQg7MLkcQmCTreL5q8bETIsdLAPoijwyQOoU tDzyHoJsRJ41I+vtWX8+IP8zuomM0A3VqheVbLXsG6yP7ZmXmfuVUmkghQUS2Bnb7E N5wXdOs42HSpN0YED8QlruXvr8TwRWLraS9TwiLE=
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1496748460; bh=5E92Orz+dwEcqGycZWz66OjMMBA6TzUfKrbps29ZKyU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IS7J7w54y7NLpHa2CSIVkACqP5AU6h7m7Nzt544jH8Q5Xsa/t4st53VETdMtgW2YL of4RedC6eyihtCEPnAhbCD2PC1MKSF4+RRkrYxiLKuau1kddohuULlDdmmVEMtpk1m ls+w6fSplla2Ajsw7o2ynDAwV6xnzL9lZodId0mE=
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding	7bit
X-Sender	kgunda@codeaurora.org
User-Agent	Roundcube Webmail/1.2.5
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	Abhijeet Dharmapurikar <adharmap@codeaurora.org>, David Collins <collinsd@codeaurora.org>, Christophe JAILLET <christophe.jaillet@wanadoo.fr>, Subbaraman Narayanamurthy <subbaram@codeaurora.org>, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, adharmap@quicinc.com, aghayal@qti.qualcomm.com, linux-arm-msm-owner@vger.kernel.org
X-Original-Date	Tue, 06 Jun 2017 16:57:40 +0530
X-Original-Message-ID	<644a2fd1dc36c3fd4ee5cd7f835c41a9@codeaurora.org>
X-Original-References	<1496147943-25822-1-git-send-email-kgunda@codeaurora.org> <1496147943-25822-15-git-send-email-kgunda@codeaurora.org> <20170531175330.GE20170@codeaurora.org> <d1918501c561801285354807fefb7b9b@codeaurora.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1658653

Show key headers only | View raw

On 2017-06-02 12:56, kgunda@codeaurora.org wrote:
> On 2017-05-31 23:23, Stephen Boyd wrote:
>> On 05/30, Kiran Gunda wrote:
>>> From: Subbaraman Narayanamurthy <subbaram@codeaurora.org>
>>> 
>>> Currently, cleanup_irq() is invoked when a peripheral's interrupt
>>> fires and there is no mapping present in the interrupt domain of
>>> spmi interrupt controller.
>>> 
>>> The cleanup_irq clears the arbiter bit, clears the pmic interrupt
>>> and disables it at the pmic in that order. The last disable in
>>> cleanup_irq races with request_irq() in that it stomps over the
>>> enable issued by request_irq. Fix this by not writing to the pmic
>>> in cleanup_irq. The latched bit will be left set in the pmic,
>>> which will not send us more interrupts even if the enable bit
>>> stays enabled.
>>> 
>>> When a client wants to request an interrupt, use the activate
>>> callback on the irq_domain to clear latched bit. This ensures
>>> that the latched, if set due to the above changes in cleanup_irq
>>> or when the bootloader leaves it set, gets cleaned up, paving way
>>> for upcoming interrupts to trigger.
>>> 
>>> With this, there is a possibility of unwanted triggering of
>>> interrupt right after the latched bit is cleared - the interrupt
>>> may be left enabled too. To avoid that, clear the enable first
>>> followed by clearing the latched bit in the activate callback.
>>> 
>>> Signed-off-by: Subbaraman Narayanamurthy <subbaram@codeaurora.org>
>>> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> 
>> Please squash this with the patch that adds cleanup_irq() and
>> rewrite the commit text to combine details from both.
> Sure. Will squash it in the next patch submission.
Patch that adds cleanup_irq is already taken in to the tree.
Lets have this patch as is now.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V1 14/15] spmi: pmic-arb: do not ack and clear peripheral interrupts in cleanup_irq Kiran Gunda <kgunda@codeaurora.org> - 2017-05-30 14:50 +0200
  Re: [PATCH V1 14/15] spmi: pmic-arb: do not ack and clear peripheral  interrupts in cleanup_irq Stephen Boyd <sboyd@codeaurora.org> - 2017-05-31 20:00 +0200
    Re: [PATCH V1 14/15] spmi: pmic-arb: do not ack and clear peripheral  interrupts in cleanup_irq kgunda@codeaurora.org - 2017-06-02 09:30 +0200
      Re: [PATCH V1 14/15] spmi: pmic-arb: do not ack and clear peripheral  interrupts in cleanup_irq kgunda@codeaurora.org - 2017-06-06 13:30 +0200

csiph-web