Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code

From	Alan Cox <gnomes@lxorguk.ukuu.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code
Date	2017-06-06 13:30 +0200
Message-ID	<tPkQp-89v-11@gated-at.bofh.it> (permalink)
References	<tPknn-7Bq-5@gated-at.bofh.it> <tPknq-7Bq-57@gated-at.bofh.it>
Organization	Intel Corporation

Show all headers | View raw

On Tue,  6 Jun 2017 12:54:40 +0200
Johan Hovold <johan@kernel.org> wrote:

> Remove three ifdefed and broken implementations of TIOCSSERIAL and
> TIOCGICOUNT, and parity handling in set_termios which had suffered
> severe bit rot.

I would be amazed if the IRDA code still works. It's not been tested
properly for years and it never followed the tty rules properly in the
first place - so this looks good, although moving IRDA into staging
and /dev/null would IMHO be far better.

IRDA is dead, and IR remotes are handled via completely different code.

Alan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 8/9] tty: ircomm: remove dead and broken ioctl code Johan Hovold <johan@kernel.org> - 2017-06-06 13:00 +0200
  Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code Alan Cox <gnomes@lxorguk.ukuu.org.uk> - 2017-06-06 13:30 +0200

csiph-web