Re: [RFC][PATCH 1/3] rt_mutex: Add lockdep annotations

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH 1/3] rt_mutex: Add lockdep annotations
Date	2017-06-06 10:20 +0200
Message-ID	<tPhSy-6bR-5@gated-at.bofh.it> (permalink)
References	<tNdJo-6BP-5@gated-at.bofh.it> <tNdJo-6BP-7@gated-at.bofh.it> <tOEHv-6ij-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Jun 04, 2017 at 04:26:43PM +0200, Thomas Gleixner wrote:
> On Wed, 31 May 2017, Peter Zijlstra wrote:
> 
> > Now that (PI) futexes have their own private RT-mutex interface and
> > implementation we can easily add lockdep annotations to the existing
> > RT-mutex interface.
> > 
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > ---
> >  include/linux/rtmutex.h        |   25 +++++++++++++++++++++----
> >  kernel/locking/rtmutex-debug.c |    6 +++++-
> 
> Shouldn't we get rid of all that home brewn rtmutex debug muck?

mutex also still has its mutex-debug.* stuff. It validates a little more
state. Also, and I think this is the main benefit, it has the magic bits
in that detect corruption without the full space/time costs of lockdep.

Maybe we can trim the rtmutex-debug a wee bit, but then futexes don't
get that coverage.

I'll put looking at this on the todo list.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC][PATCH 1/3] rt_mutex: Add lockdep annotations Peter Zijlstra <peterz@infradead.org> - 2017-05-31 17:30 +0200
  Re: [RFC][PATCH 1/3] rt_mutex: Add lockdep annotations Thomas Gleixner <tglx@linutronix.de> - 2017-06-04 16:30 +0200
    Re: [RFC][PATCH 1/3] rt_mutex: Add lockdep annotations Peter Zijlstra <peterz@infradead.org> - 2017-06-06 10:20 +0200

csiph-web