Re: [PATCH 16/16] platform/x86: dell-wmi: Convert to the WMI bus infrastructure

From	Darren Hart <dvhart@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 16/16] platform/x86: dell-wmi: Convert to the WMI bus infrastructure
Date	2017-06-06 05:10 +0200
Message-ID	<tPd2y-3dl-13@gated-at.bofh.it> (permalink)
References	(2 earlier) <tLHBU-2aL-7@gated-at.bofh.it> <tLMrU-6fP-37@gated-at.bofh.it> <tLMBA-6jn-23@gated-at.bofh.it> <tLOWJ-7Id-5@gated-at.bofh.it> <tMFol-XX-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, May 29, 2017 at 07:45:05PM -0700, Dmitry Torokhov wrote:
> On Sat, May 27, 2017 at 11:40:52AM -0700, Andy Lutomirski wrote:
> > On Sat, May 27, 2017 at 9:17 AM, Dmitry Torokhov
> > <dmitry.torokhov@gmail.com> wrote:
> > > On May 27, 2017 9:04:38 AM PDT, Andy Lutomirski <luto@kernel.org> wrote:
> > >>On Sat, May 27, 2017 at 3:50 AM, Pali Rohár <pali.rohar@gmail.com>
> > >>wrote:
> > >>> On Saturday 27 May 2017 07:31:30 Darren Hart wrote:
> > >>>> -     dell_wmi_input_dev->name = "Dell WMI hotkeys";
> > >>>> -     dell_wmi_input_dev->phys = "wmi/input0";
> > >>>> -     dell_wmi_input_dev->id.bustype = BUS_HOST;
> > >>>> +     priv->input_dev->name = "Dell WMI hotkeys";
> > >>>> +     priv->input_dev->id.bustype = BUS_HOST;
> > >>>
> > >>> Is not there BUS_WMI, or something like that? (Just asking)
> > >>>
> > >>
> > >>Jiri and/or Dmitry, what is bustype for, anyway?
> > >
> > > The bus type could be used to help further  identifying device if it used same vendor/product for spi and i2c, for example, but there are not many if them. I'm not sure if anyone actually makes decisions based on it, but it is part of abi now.
> > >
> > >>I suppose we could add BUS_PLATFORM.
> > >
> > > What would be the difference from BUS_HOST?
> > >
> > 
> > If BUS_HOST means that the device is part of the host as opposed to
> > being plugged in, then it seems entirely reasonable.
> 
> Yes, it basically means platform-specific interface.
> 

I'm going to leave this as BUS_HOST then. Thanks everyone.

-- 
Darren Hart
VMware Open Source Technology Center

Thread

[PATCH 00/16] Convert WMI to a proper bus Darren Hart <dvhart@infradead.org> - 2017-05-27 07:40 +0200
  [PATCH 11/16] platform/x86: wmi: Add a new interface to read block data Darren Hart <dvhart@infradead.org> - 2017-05-27 07:40 +0200
  [PATCH 02/16] platform/x86: wmi: Pass the acpi_device through to parse_wdg Darren Hart <dvhart@infradead.org> - 2017-05-27 07:40 +0200
  [PATCH 04/16] platform/x86: wmi: Track wmi devices per ACPI device Darren Hart <dvhart@infradead.org> - 2017-05-27 07:40 +0200
  [PATCH 16/16] platform/x86: dell-wmi: Convert to the WMI bus infrastructure Darren Hart <dvhart@infradead.org> - 2017-05-27 07:40 +0200
    Re: [PATCH 16/16] platform/x86: dell-wmi: Convert to the WMI bus infrastructure Pali Rohár <pali.rohar@gmail.com> - 2017-05-27 13:00 +0200
      Re: [PATCH 16/16] platform/x86: dell-wmi: Convert to the WMI bus infrastructure Andy Lutomirski <luto@kernel.org> - 2017-05-27 18:10 +0200
        Re: [PATCH 16/16] platform/x86: dell-wmi: Convert to the WMI bus infrastructure Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-05-27 18:20 +0200
          Re: [PATCH 16/16] platform/x86: dell-wmi: Convert to the WMI bus infrastructure Andy Lutomirski <luto@kernel.org> - 2017-05-27 20:50 +0200
            Re: [PATCH 16/16] platform/x86: dell-wmi: Convert to the WMI bus  infrastructure Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-05-30 04:50 +0200
              Re: [PATCH 16/16] platform/x86: dell-wmi: Convert to the WMI bus  infrastructure Darren Hart <dvhart@infradead.org> - 2017-06-06 05:10 +0200
  Re: [PATCH 00/16] Convert WMI to a proper bus "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-05-27 22:00 +0200
    Re: [PATCH 00/16] Convert WMI to a proper bus Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-27 22:10 +0200
  Re: [PATCH 00/16] Convert WMI to a proper bus Darren Hart <dvhart@infradead.org> - 2017-06-06 19:30 +0200

csiph-web