Re: [PATCH v2] [media] vb2: core: Lower the log level of debug outputs

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] [media] vb2: core: Lower the log level of debug outputs
Date	2017-06-08 07:20 +0200
Message-ID	<tPY1r-8ro-1@gated-at.bofh.it> (permalink)
References	(4 earlier) <tN37k-8e3-17@gated-at.bofh.it> <tN37k-8e3-15@gated-at.bofh.it> <tPF8u-4Fk-7@gated-at.bofh.it> <tPWiZ-7ci-3@gated-at.bofh.it> <tPXoJ-7V3-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2017-06-08 at 13:39 +0900, Tomasz Figa wrote:
> On Thu, Jun 8, 2017 at 12:24 PM, Hirokazu Honda <hiroh@chromium.org> wrote:
> > Hi,
> > 
> > I completely understand bitmask method now.
> > I agree to the idea, but it is necessary to change the specification of
> > a debug parameter.
> >  (We probably need to change a document about that?)
> > For example, there is maybe a user who set a debug parameter 3.
> > The user assume that logs whose levels are less than 4 are shown.
> > However, after the bitmask method is adopted, someday the logs whose
> > level is 1 or 2 are only shown, not 3 level logs are not shown.
> > This will be confusing to users.
> 
> I think I have to agree with Hirokazu here. Even though it's only
> about debugging, there might be some automatic testing systems that
> actually rely on certain values here.

I think it's a non-argument.

If there automated systems that rely on specific levels, then
changing the levels of individual messages could also cause
those automated systems to fail.

Thread

Re: [PATCH v2] [media] vb2: core: Lower the log level of debug outputs Hirokazu Honda <hiroh@chromium.org> - 2017-06-08 05:30 +0200
  Re: [PATCH v2] [media] vb2: core: Lower the log level of debug outputs Tomasz Figa <tfiga@google.com> - 2017-06-08 06:40 +0200
    Re: [PATCH v2] [media] vb2: core: Lower the log level of debug  outputs Joe Perches <joe@perches.com> - 2017-06-08 07:20 +0200
      Re: [PATCH v2] [media] vb2: core: Lower the log level of debug outputs Tomasz Figa <tfiga@chromium.org> - 2017-06-08 07:30 +0200
        Re: [PATCH v2] [media] vb2: core: Lower the log level of debug  outputs Joe Perches <joe@perches.com> - 2017-06-08 07:40 +0200

csiph-web