Re: [PATCH v4 11/13] net/route: use get_random_int for random counter

From	Theodore Ts'o <tytso@mit.edu>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 11/13] net/route: use get_random_int for random counter
Date	2017-06-08 05:10 +0200
Message-ID	<tPVZE-76l-11@gated-at.bofh.it> (permalink)
References	<tPqM9-3tE-3@gated-at.bofh.it> <tPqM9-3tE-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 06, 2017 at 07:48:02PM +0200, Jason A. Donenfeld wrote:
> Using get_random_int here is faster, more fitting of the use case, and
> just as cryptographically secure. It also has the benefit of providing
> better randomness at early boot, which is when many of these structures
> are assigned.
> 
> Also, semantically, it's not really proper to have been assigning an
> atomic_t in this way before, even if in practice it works fine.
> 
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> Cc: David Miller <davem@davemloft.net>

Applied to the dev branch of the random.git branch, thanks.

	       	   	     	 	    - Ted

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v4 11/13] net/route: use get_random_int for random counter Theodore Ts'o <tytso@mit.edu> - 2017-06-08 05:10 +0200

csiph-web