Re: [PATCH] clk: sunxi-ng: Move all clock types to a library

From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] clk: sunxi-ng: Move all clock types to a library
Date	2017-06-08 03:50 +0200
Message-ID	<tPUKe-65e-11@gated-at.bofh.it> (permalink)
References	(2 earlier) <tP1uq-499-21@gated-at.bofh.it> <tPjB0-7ik-21@gated-at.bofh.it> <tPC0V-2oJ-3@gated-at.bofh.it> <tPDJo-3zy-29@gated-at.bofh.it> <tPEm5-44h-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2017-06-07 17:17 GMT+09:00 Maxime Ripard <maxime.ripard@free-electrons.com>:
> On Wed, Jun 07, 2017 at 09:36:34AM +0200, Arnd Bergmann wrote:
>> On Wed, Jun 7, 2017 at 7:45 AM, Chen-Yu Tsai <wens@csie.org> wrote:
>> > at the bottom (with a comment) would be cleaner, and
>> > we wouldn't need to modify all the existing lines.
>> > AFAIK about Makefiles, that should work?
>>
>> Ah, yes. That's much better.
>>
>>       Arnd
>
> I just applied the original patch, with that addition, and a comment
> as suggested by Stephen.
>

Hmm, I think Kbuild expects lib.a only for the final link
(at least in official level)
Is it a problem to compile common files all the time?

# Common objects
obj-y += ccu_common.o
obj-y += ccu_reset.o

We may end up with some unused functions in vmlinux,
but it will not be a big impact on the image size in this case.

CONFIG_LD_DEAD_CODE_DATA_ELIMINATION may
take care of unused symbols.  I have not tested this CONFIG, though.

-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] clk: sunxi-ng: Move all clock types to a library Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-08 03:50 +0200

csiph-web