Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1660287

Re: [PATCH] gpio: mvebu: change compatible string for PWM support

Show all headers | View raw

On Thu, Jun 01, 2017 at 10:08:20PM +0200, Ralph Sennhauser wrote:
> As it turns out more than just Armada 370 and XP support using GPIO
> lines as PWM lines. For example the Armada 38x family has the same
> hardware support. As such "marvell,armada-370-xp-gpio" for the
> compatible string is a misnomer.
> 
> Change the compatible string to "marvell,armada-370-gpio" before the
> driver makes it out of the -rc stage. This also follows the practice of
> using only the first device family supported as part of the name.
> 
> Also update the documentation and comments in the code accordingly.
> 
> Fixes: 757642f9a584 ("gpio: mvebu: Add limited PWM support")
> Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
> 
> ---
> 
> Hi everyone,
> 
> The suggestion to change the compatible string last minute comes from
> Gregory CLEMENT after we realized the bad choice of name due to Richard
> Genoud reporting an issue when he used the driver with an Armada-388.
> 
> Rob Herring just requested to use a separate compatible string but not
> what it should look like. So I assume he is fine with the new one as
> well. The rest of this patch is rather minor.
> 
> Nothing in tree is using this driver so far, first consumers will be
> added with 4.13.
> 
> Ralph
> 
> ---
>  Documentation/devicetree/bindings/gpio/gpio-mvebu.txt | 6 +++---
>  drivers/gpio/gpio-mvebu.c                             | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] gpio: mvebu: change compatible string for PWM support Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-06-01 22:10 +0200
  Re: [PATCH] gpio: mvebu: change compatible string for PWM support Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-06-02 11:30 +0200
  Re: [PATCH] gpio: mvebu: change compatible string for PWM support Rob Herring <robh@kernel.org> - 2017-06-08 00:20 +0200
  Re: [PATCH] gpio: mvebu: change compatible string for PWM support Richard Genoud <richard.genoud@gmail.com> - 2017-06-09 09:50 +0200
    Re: [PATCH] gpio: mvebu: change compatible string for PWM support Linus Walleij <linus.walleij@linaro.org> - 2017-06-16 11:20 +0200
  Re: [PATCH] gpio: mvebu: change compatible string for PWM support Linus Walleij <linus.walleij@linaro.org> - 2017-06-09 09:50 +0200
    Re: [PATCH] gpio: mvebu: change compatible string for PWM support Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-06-09 22:20 +0200

csiph-web