Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1660297

Re: [PATCH v2 2/6] dt-bindings: interrupt-controller: add DT binding for the Marvell ICU

Show all headers | View raw

On Fri, Jun 02, 2017 at 12:06:53PM +0200, Thomas Petazzoni wrote:
> This commit adds the Device Tree binding documentation for the Marvell
> ICU interrupt controller, which collects wired interrupts from the
> devices located into the CP110 hardware block of Marvell Armada 7K/8K,
> and converts them into SPI interrupts in the GIC located in the AP
> hardware block, using the GICP extension.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  .../bindings/interrupt-controller/marvell,icu.txt  | 54 ++++++++++++++++++++++
>  1 file changed, 54 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/marvell,icu.txt
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/marvell,icu.txt b/Documentation/devicetree/bindings/interrupt-controller/marvell,icu.txt
> new file mode 100644
> index 0000000..3e7954c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/marvell,icu.txt
> @@ -0,0 +1,54 @@
> +Marvell ICU Interrupt Controller
> +--------------------------------
> +
> +The Marvell ICU (Interrupt Consolidation Unit) controller is
> +responsible for collecting all wired-interrupt sources in the CP and
> +communicating them to the GIC in the AP, the unit translates interrupt
> +requests on input wires to MSG memory mapped transactions to the GIC.
> +
> +Required properties:
> +
> +- compatible: Should be "marvell,cp110-icu"
> +
> +- reg: Should contain ICU registers location and length.
> +
> +- #interrupt-cells: Specifies the number of cells needed to encode an
> +  interrupt source. The value shall be 3.
> +
> +  The 1st cell is the group type of the ICU interrupt. Possible group
> +  types are:
> +
> +   ICU_GRP_NSR (0x0) : Shared peripheral interrupt, non-secure
> +   ICU_GRP_SR  (0x1) : Shared peripheral interrupt, secure
> +   ICU_GRP_SEI (0x4) : System error interrupt
> +   ICU_GRP_REI (0x5) : RAM error interrupt
> +
> +  The 2nd cell is the index of the interrupt in the ICU unit.
> +
> +  The 3rd cell is the type of the interrupt. See arm,gic.txt for
> +  details.
> +
> +- interrupt-controller: Identifies the node as an interrupt
> +  controller.
> +
> +- interrupt-parent: Indicates the node of the parent interrupt
> +  controller. Should be pointer to the GIC.
> +
> +- gicp: Should point to the GICP controller, the GIC extension that
> +  allows to trigger interrupts using MSG memory mapped transactions.
> +
> +Example:
> +
> +icu: interrupt-controller@1e0000 {
> +	compatible = "marvell,cp110-icu";
> +	reg = <0x1e0000 0x10>;
> +	#interrupt-cells = <3>;
> +	interrupt-controller;
> +	interrupt-parent = <&gic>;

If you have a parent, then you should have some interrupts. I guess that 
would be your ranges property? I suppose that is fine.

> +	marvell,gicp = <&gicp>;
> +};
> +
> +usb3h0: usb3@500000 {
> +	interrupt-parent = <&icu>;
> +	interrupts = <ICU_GRP_NSR 106 IRQ_TYPE_LEVEL_HIGH>;
> +};
> -- 
> 2.7.4
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/6] Add support for the ICU unit in Marvell Armada 7K/8K Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-06-02 12:10 +0200
  [PATCH v2 2/6] dt-bindings: interrupt-controller: add DT binding for the Marvell ICU Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-06-02 12:10 +0200
    Re: [PATCH v2 2/6] dt-bindings: interrupt-controller: add DT binding  for the Marvell ICU Rob Herring <robh@kernel.org> - 2017-06-08 00:40 +0200
      Re: [PATCH v2 2/6] dt-bindings: interrupt-controller: add DT  binding for the Marvell ICU Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-06-08 14:20 +0200
        Re: [PATCH v2 2/6] dt-bindings: interrupt-controller: add DT binding  for the Marvell ICU Rob Herring <robh@kernel.org> - 2017-06-09 00:00 +0200
  [PATCH v2 4/6] irqchip: irq-mvebu-icu: new driver for Marvell ICU Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-06-02 12:10 +0200
  [PATCH v2 6/6] arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-06-02 12:10 +0200
  [PATCH v2 5/6] arm64: marvell: enable ICU and GICP drivers Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-06-02 12:10 +0200
  [PATCH v2 3/6] irqchip: irq-mvebu-gicp: new driver for Marvell GICP Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-06-02 12:10 +0200
    Re: [PATCH v2 3/6] irqchip: irq-mvebu-gicp: new driver for Marvell  GICP Marc Zyngier <marc.zyngier@arm.com> - 2017-06-08 17:10 +0200
  Re: [PATCH v2 0/6] Add support for the ICU unit in Marvell Armada 7K/8K Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-06-06 18:30 +0200

csiph-web