Re: [PATCH v3 3/6] perf tools: Decompress kernel module when reading DSO data

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 3/6] perf tools: Decompress kernel module when reading DSO data
Date	2017-06-08 00:30 +0200
Message-ID	<tPRCG-4az-15@gated-at.bofh.it> (permalink)
References	<tPLdT-8rQ-5@gated-at.bofh.it> <tPLdT-8rQ-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Thu, Jun 08, 2017 at 12:39:00AM +0900, Namhyung Kim escreveu:
> Currently perf decompresses kernel modules when loading symbol table but
> it missed to do it when reading raw data.
> 
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  tools/perf/util/dso.c | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
> index 59257ce4580e..2a0c689227f8 100644
> --- a/tools/perf/util/dso.c
> +++ b/tools/perf/util/dso.c
> @@ -463,8 +463,22 @@ static int __open_dso(struct dso *dso, struct machine *machine)
>  		return -EINVAL;
>  	}
>  
> -	if (!is_regular_file(name))
> +	if (!is_regular_file(name)) {
> +		free(name);
>  		return -EINVAL;
> +	}

Humm, this looks like something for a separate patch? Its a pre-existing
leak, separate issue.

That error path in __open_dso() could be consolidated, but the above
hunk is the minimal fix for perf/urgent, where I think your series
should go from what I've read so far, agreed?

- Arnaldo

> +
> +	if (dso__needs_decompress(dso)) {
> +		char newpath[KMOD_DECOMP_LEN];
> +		size_t len = sizeof(newpath);
> +
> +		if (dso__decompress_kmodule_path(dso, name, newpath, len) < 0) {
> +			free(name);
> +			return -1;
> +		}
> +
> +		strcpy(name, newpath);
> +	}
>  
>  	fd = do_open(name);
>  	free(name);
> -- 
> 2.13.0

Thread

[PATCHSET v3 0/6] perf tools: Fix for Compressed kernel modules Namhyung Kim <namhyung@kernel.org> - 2017-06-07 17:40 +0200
  [PATCH v3 3/6] perf tools: Decompress kernel module when reading DSO data Namhyung Kim <namhyung@kernel.org> - 2017-06-07 17:40 +0200
    Re: [PATCH v3 3/6] perf tools: Decompress kernel module when reading  DSO data Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-08 00:30 +0200
      Re: [PATCH v3 3/6] perf tools: Decompress kernel module when reading  DSO data Namhyung Kim <namhyung@kernel.org> - 2017-06-08 02:00 +0200
  [PATCH v3 2/6] perf annotate: Use dso__decompress_kmodule_path() Namhyung Kim <namhyung@kernel.org> - 2017-06-07 17:40 +0200
  [PATCH v3 6/6] perf symbols: Kill dso__build_id_is_kmod() Namhyung Kim <namhyung@kernel.org> - 2017-06-07 17:50 +0200
  [PATCH v3 4/6] perf test: Decompress kernel module before objdump Namhyung Kim <namhyung@kernel.org> - 2017-06-07 17:50 +0200
    Re: [PATCH v3 4/6] perf test: Decompress kernel module before objdump Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-08 00:30 +0200
      Re: [PATCH v3 4/6] perf test: Decompress kernel module before objdump Namhyung Kim <namhyung@kernel.org> - 2017-06-08 02:00 +0200
      Re: [PATCH v3 4/6] perf test: Decompress kernel module before objdump Namhyung Kim <namhyung@kernel.org> - 2017-06-08 02:40 +0200
  [PATCH v3 5/6] perf symbols: Keep DSO->symtab_type after decompress Namhyung Kim <namhyung@kernel.org> - 2017-06-07 17:50 +0200
  [PATCH v3 1/6] perf tools: Introduce dso__decompress_kmodule_{fd,path} Namhyung Kim <namhyung@kernel.org> - 2017-06-07 17:50 +0200

csiph-web