Re: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages

From	Darwin Dingel <Darwin.Dingel@alliedtelesis.co.nz>
Newsgroups	linux.kernel
Subject	Re: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages
Date	2017-06-08 00:00 +0200
Message-ID	<tPR9F-3Ll-33@gated-at.bofh.it> (permalink)
References	<tLawi-6pJ-17@gated-at.bofh.it> <tNiJ3-1iM-3@gated-at.bofh.it> <tPR9F-3Ll-35@gated-at.bofh.it> <tNk89-2vg-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Pavel,

Looks like uboot has similar IFC driver. Do you have plans to apply this change to uboot as well?


Cheers,
Darwin


From: Pavel Machek <pavel@ucw.cz>
Sent: Thursday, 1 June 2017 10:15 a.m.
To: Darwin Dingel
Cc: Boris Brezillon; richard@nod.at; dwmw2@infradead.org; computersforpeace@gmail.com; marek.vasut@gmail.com; cyrille.pitchen@atmel.com; linux-mtd@lists.infradead.org; linux-kernel@vger.kernel.org; mark.marshall@omicronenergy.com; b44839@freescale.com;  prabhakar@freescale.com
Subject: Re: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages
    
Hi!

> > You meen "errors = 0"? Does that actually make a difference? It is a
> > local variable, and continue makes sure the value is not used:
> > 
> 
> I missed the 'continue' statement there. In that case we don't need to 
> reset 'error'.

Yes, thanks, I wanted to double-check. If you could take a look at
PATCHv2 -- it should have the problems fixed. Your Acked-by would be
nice ;-).

Thanks a lot,
                                                                        Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)  http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Thread

Re: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages Darwin Dingel <Darwin.Dingel@alliedtelesis.co.nz> - 2017-05-26 01:40 +0200
  Re: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-29 10:50 +0200
    Re: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages Pavel Machek <pavel@ucw.cz> - 2017-06-01 00:20 +0200
  Re: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages Pavel Machek <pavel@ucw.cz> - 2017-05-31 22:50 +0200
    Re: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages Darwin Dingel <Darwin.Dingel@alliedtelesis.co.nz> - 2017-06-01 00:00 +0200
      Re: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages Pavel Machek <pavel@ucw.cz> - 2017-06-01 00:20 +0200
        Re: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages Darwin Dingel <Darwin.Dingel@alliedtelesis.co.nz> - 2017-06-08 00:00 +0200
          Re: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages Pavel Machek <pavel@ucw.cz> - 2017-06-13 10:30 +0200

csiph-web