[PATCH] scsi: remove useless variable assignment

From	"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Newsgroups	linux.kernel
Subject	[PATCH] scsi: remove useless variable assignment
Date	2017-06-07 23:00 +0200
Message-ID	<tPQdB-38j-45@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Remove both variable assignments once the value stored in variable _reqlen_
is overwritten at some point either by line 2321: reqlen = mptr - msg;
or by line 2330: reqlen = 12;

Addresses-Coverity-ID: 1226930
Addresses-Coverity-ID: 1226931
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
  drivers/scsi/dpt_i2o.c | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index 256dd67..acad668 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -2292,11 +2292,8 @@ static s32 adpt_scsi_to_i2o(adpt_hba* pHba,  
struct scsi_cmnd* cmd, struct adpt_d
  	mptr+=4;
  	lenptr=mptr++;		/* Remember me - fill in when we know */
  	if (dpt_dma64(pHba)) {
-		reqlen = 16;		// SINGLE SGE
  		*mptr++ = (0x7C<<24)+(2<<16)+0x02; /* Enable 64 bit */
  		*mptr++ = 1 << PAGE_SHIFT;
-	} else {
-		reqlen = 14;		// SINGLE SGE
  	}
  	/* Now fill in the SGList and command */

--
2.5.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] scsi: remove useless variable assignment "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-07 23:00 +0200

csiph-web