Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1660193

Re: [RFC] clang: 'unused-function' warning on static inline functions

From Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [RFC] clang: 'unused-function' warning on static inline functions
Date 2017-06-07 22:40 +0200
Message-ID <tPPUf-30Y-29@gated-at.bofh.it> (permalink)
References (2 earlier) <tPkGJ-82Q-5@gated-at.bofh.it> <tPpGq-2N6-17@gated-at.bofh.it> <tPud4-5O1-17@gated-at.bofh.it> <tPud4-5O1-15@gated-at.bofh.it> <tPP7Q-2ta-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Jun 7, 2017 at 12:43 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>
> The main reason I see for it is that a lot of the unused inline functions
> in C files are mistakes,

Bah. Blah blah blah.

The clang warnign doesn't actually really buy us anything, and it's a
completely pointless difference to gcc.

I'm not in the least interested in supporting these kinds of pointless
differences.

The people who are interested in making the kernel compile well with
clang should care about the things that matter, not annoying people
with idiotic patches.

So stop the idiotic patches.  When clang actually adds _value_, that's
one thing. Right now it's just stupid noise.

For some reason compiler people think that "more warnings are good".
No. They are not. More noise without any value is absolutely not good,
and an unused inline function si by definition not something we care
about.

Really. Fit the clang noise. Get clang to generate good code.

Once clang has actually proven itself, and we haev years of clang
under our belt, and clang isn't just a toy and a source of bugs and
pointless warnings as far as kernel builds are concerned, THEN we can
start talking about actually making use of clang features.

Right now it should be about "don't be a f*cking pain in the arse!"

            Linus

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC] clang: 'unused-function' warning on static inline functions Matthias Kaehlcke <mka@chromium.org> - 2017-05-30 20:20 +0200
  Re: [RFC] clang: 'unused-function' warning on static inline functions Matthias Kaehlcke <mka@chromium.org> - 2017-06-01 02:00 +0200
    Re: [RFC] clang: 'unused-function' warning on static inline functions Arnd Bergmann <arnd@arndb.de> - 2017-06-06 13:20 +0200
      Re: [RFC] clang: 'unused-function' warning on static inline functions Linus Torvalds <torvalds@linux-foundation.org> - 2017-06-06 18:40 +0200
        Re: [RFC] clang: 'unused-function' warning on static inline functions Matthias Kaehlcke <mka@chromium.org> - 2017-06-06 23:30 +0200
          Re: [RFC] clang: 'unused-function' warning on static inline functions Linus Torvalds <torvalds@linux-foundation.org> - 2017-06-06 23:30 +0200
            Re: [RFC] clang: 'unused-function' warning on static inline functions Matthias Kaehlcke <mka@chromium.org> - 2017-06-07 02:30 +0200
              Re: [RFC] clang: 'unused-function' warning on static inline  functions David Rientjes <rientjes@google.com> - 2017-06-07 08:00 +0200
            Re: [RFC] clang: 'unused-function' warning on static inline functions Arnd Bergmann <arnd@arndb.de> - 2017-06-07 21:50 +0200
              Re: [RFC] clang: 'unused-function' warning on static inline functions Linus Torvalds <torvalds@linux-foundation.org> - 2017-06-07 22:40 +0200
                Re: [RFC] clang: 'unused-function' warning on static inline  functions Steven Rostedt <rostedt@goodmis.org> - 2017-06-07 23:30 +0200
              Re: [RFC] clang: 'unused-function' warning on static inline functions Arnd Bergmann <arnd@arndb.de> - 2017-06-08 11:00 +0200
          Re: [RFC] clang: 'unused-function' warning on static inline functions Jens Axboe <axboe@kernel.dk> - 2017-06-06 23:30 +0200
            Re: [RFC] clang: 'unused-function' warning on static inline functions Arnd Bergmann <arnd@arndb.de> - 2017-06-07 10:20 +0200
              Re: [RFC] clang: 'unused-function' warning on static inline  functions Steven Rostedt <rostedt@goodmis.org> - 2017-06-07 15:00 +0200
                Re: [RFC] clang: 'unused-function' warning on static inline functions Arnd Bergmann <arnd@arndb.de> - 2017-06-07 15:20 +0200

csiph-web