Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1660151

Re: [PATCH net-next 2/5] net: dsa: check VLAN capability of every switch

Show all headers | View raw

On 06/06/2017 01:56 PM, Vivien Didelot wrote:
> Now that the VLAN object is propagated to every switch chip of the
> switch fabric, we can easily ensure that they all support the required
> VLAN operations before modifying an entry on a single switch.
> 
> To achieve that, remove the condition skipping other target switches,
> and add a bitmap of VLAN members, eventually containing the target port,
> if we are programming the switch target.

You could add in the commit message that with this commit, there is not
actually a functional change yet because we have one (and only one) bit
set in the members bitmap.

> 
> This will allow us to easily add other VLAN members, such as the DSA or
> CPU ports (to introduce cross-chip VLAN support) or the other port
> members if we want to reduce hardware accesses later.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 2/5] net: dsa: check VLAN capability of every switch Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-06-06 23:00 +0200
  Re: [PATCH net-next 2/5] net: dsa: check VLAN capability of every  switch Florian Fainelli <f.fainelli@gmail.com> - 2017-06-07 21:50 +0200
    Re: [PATCH net-next 2/5] net: dsa: check VLAN capability of every switch Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-06-07 22:10 +0200

csiph-web