Re: [PATCH] Input: synaptics_rmi4 - register F03 port as pass-through serio

Path	csiph.com!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Input: synaptics_rmi4 - register F03 port as pass-through serio
Date	Wed, 07 Jun 2017 19:00:02 +0200
Message-ID	<tPMtk-J4-13@gated-at.bofh.it> (permalink)
References	<tPD6G-34T-17@gated-at.bofh.it> <tPDgl-3om-1@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CdXSqKFOCsdddlgVsuj5tPQeg+47wJkzxQ5EigvGMZU=; b=VR1cyQzjif4P2GxH4Yide0XwOxpl+wj4OyL/EIJLiGpmJkfisDLiROZ3Tp9l1WL6sr RuSTzklqs//menaaP0K75wn4FqFZvJScNfrsHX1gGA+ThEuDQd3ZqmfOuuDzRcxWMwm9 ARnu14S7h1kaKAZ9fn2zOUqLWWDATeO3KCuCDyVPG9fl6sbMFwJF3h4dVrKfcFfIWcng mdMjUJiTWiCLcBukuU3K4En+LpFkf0Ko9lMV2wZnw4809Pco1kIXvUeusY8xjgPd2kU7 3zThs/ZZ3Ki2LPHnfqUgLimCn0kwCz1aRUgsBS9MV4FImT/leNJQUSOlfwXLDtaH1Vjt nYtQ==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CdXSqKFOCsdddlgVsuj5tPQeg+47wJkzxQ5EigvGMZU=; b=fm6Zujfp01CAU2Q+pcLMEGfF8TwegUb+GNMHx3mgHrxGg15ghMuu/Dg1aM/klJ86BQ WK6aVkOFmyw3O8ouZJ/nVLioHor8Uz0oHMp5iL94fzm2GnNaZBNl1Nm4bkflq1FgOUx8 EFUmzOiSxOGunRQl7Znla3UY/zz6S2TfRqn7ObtA/v8aqAusNaTEh2wmx2ssQaVN01fb z5bK4lCjyCE+7recjQAawn9B1DOj42oKpEWps/LOSv6TFviTdpM9chrPmGzolu1zG5LQ xukfP2SzNzKorndoCLpA6t0m9DGCkpEweXVY/uRAgA401AeaCIjAwYLiweXHJsJqL/n/ yLoA==
X-Gm-Message-State	AODbwcAMr/mOHLFpBKmBywjl/DoaHDJBWiXtjgtiBrxGGkiALEUsl8y8 jYEzqjl4qHqMmw==
X-Received	by 10.84.238.194 with SMTP id l2mr29116426pln.247.1496854795722; Wed, 07 Jun 2017 09:59:55 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	61
Organization	linux.* mail to news gateway
X-Original-Cc	linux-input@vger.kernel.org, Andrew Duggan <aduggan@synaptics.com>, Lyude Paul <thatslyude@gmail.com>, Damjan Georgievski <gdamjan@gmail.com>, Masaki Ota <masaki.ota@jp.alps.com>, linux-kernel@vger.kernel.org
X-Original-Date	Wed, 7 Jun 2017 09:59:53 -0700
X-Original-Message-ID	<20170607165953.GB13116@dtor-ws>
X-Original-References	<20170607065128.GA31686@dtor-ws> <20170607070255.GA16591@mail.corp.redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1660018

Show key headers only | View raw

On Wed, Jun 07, 2017 at 09:02:55AM +0200, Benjamin Tissoires wrote:
> On Jun 06 2017 or thereabouts, Dmitry Torokhov wrote:
> > The 5th generation Thinkpad X1 Carbons use Synaptics touchpads accessible
> > over SMBus/RMI, combined with ALPS or Elantech trackpoint devices instead
> > of classic IBM/Lenovo trackpoints. Unfortunately there is no way for ALPS
> > driver to detect whether it is dealing with touchpad + trackpoint
> > combination or just a trackpoint, so we end up with a "phantom" dualpoint
> > ALPS device in addition to real touchpad and trackpoint.
> > 
> > Given that we do not have any special advanced handling for ALPS or
> > Elantech trackpoints (unlike IBM trackpoints that have separate driver and
> > a host of options) we are better off keeping the trackpoints in PS/2
> > emulation mode. We achieve that by setting serio type to SERIO_PS_PSTHRU,
> > which will limit number of protocols psmouse driver will try. In addition
> > to getting rid of the "phantom" touchpads, this will also speed up probing
> > of F03 pass-through port.
> > 
> > Reported-by: Damjan Georgievski <gdamjan@gmail.com>
> > Suggested-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
> 
> Thanks for the extensive commit message :)
> 
> Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Thanks Benjamin.

Damjan, could you please try this patch too before I send it Linus-wards.

> 
> (tested on a t450s without problems).
> 
> Cheers,
> Benjamin
> 
> >  drivers/input/rmi4/rmi_f03.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/input/rmi4/rmi_f03.c b/drivers/input/rmi4/rmi_f03.c
> > index 77dad045a468..ad71a5e768dc 100644
> > --- a/drivers/input/rmi4/rmi_f03.c
> > +++ b/drivers/input/rmi4/rmi_f03.c
> > @@ -146,7 +146,7 @@ static int rmi_f03_register_pt(struct f03_data *f03)
> >  	if (!serio)
> >  		return -ENOMEM;
> >  
> > -	serio->id.type = SERIO_8042;
> > +	serio->id.type = SERIO_PS_PSTHRU;
> >  	serio->write = rmi_f03_pt_write;
> >  	serio->port_data = f03;
> >  
> > -- 
> > 2.13.0.506.g27d5fe0cd-goog
> > 
> > 
> > -- 
> > Dmitry

-- 
Dmitry

Thread

[PATCH] Input: synaptics_rmi4 - register F03 port as pass-through  serio Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-06-07 09:00 +0200
  Re: [PATCH] Input: synaptics_rmi4 - register F03 port as  pass-through serio Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-06-07 09:10 +0200
    Re: [PATCH] Input: synaptics_rmi4 - register F03 port as  pass-through serio Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-06-07 19:00 +0200
      Re: [PATCH] Input: synaptics_rmi4 - register F03 port as pass-through serio Damjan Georgievski <gdamjan@gmail.com> - 2017-06-08 14:00 +0200

csiph-web