Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1659928

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

Show all headers | View raw

On 07/06/2017 at 16:17:35 +0200, Daniel Lezcano wrote:
> > You mean you don't like how it is used? Or you don't think having the
> > timer full name is useful?
> 
> The field is not needed, the only place where it is used is where we affect it.
>  

It is used in tcb_clksrc_register:

tc.clksrc.name = tc.name;

> > The main reason is that RobH doesn't want to have the use (clocksource
> > or clockevent) of the timer in the DT so when probing a timer, I need to
> > know whether I already have a clocksource to decide when it is time to
> > register a clockevent.
> 
> Yes, we had this discussion some weeks ago.
> 
> This registered hack forces the DT to define first the clocksource, then the
> clockevent.
> 
> So, I suggest you fold the timer definition into a single one like the other
> drivers.

I was going to agree but this is not flexible enough because the
quadrature decoder always uses the first two channels. So on some
products, we may have:
 - TCB0:
   o channels 0,1: qdec
   o channel 2: clocksource

 - TCB1:
   o channels 0,1: qdec
   o channel 2: clockevent

This avoids wasting TCB channels.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-05-31 00:00 +0200
  Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-06-06 17:30 +0200
    Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-06 20:10 +0200
      Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-06-07 16:20 +0200
        Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-07 17:10 +0200
          Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-06-07 23:40 +0200
            Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-08 01:20 +0200
            Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-06-08 09:00 +0200
        Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-07 17:30 +0200
          Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-06-07 23:10 +0200
            Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-08 01:20 +0200
              Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-06-08 07:50 +0200
                Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-06-08 09:50 +0200
                Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-08 10:00 +0200
                Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-06-08 10:30 +0200
                Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-06-08 10:40 +0200
                Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-08 10:50 +0200
                Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-06-08 10:20 +0200
                Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-06-08 10:50 +0200
                Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-06-08 11:00 +0200
                Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel  ARM TC blocks Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-06-12 15:00 +0200
                Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel  ARM TC blocks Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-06-12 15:30 +0200
                Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel  ARM TC blocks Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-06-12 17:30 +0200
            Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the  Atmel ARM TC blocks Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-06-08 08:30 +0200

csiph-web