Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1659868

Re: [PATCH v2] decnet: dn_rtmsg: Improve input length sanitization in dnrmg_receive_user_skb

Show all headers | View raw

On Wed, Jun 7, 2017 at 4:18 PM, Florian Westphal <fw@strlen.de> wrote:
> Mateusz Jurczyk <mjurczyk@google.com> wrote:
>> Verify that the length of the socket buffer is sufficient to cover the
>> nlmsghdr structure before accessing the nlh->nlmsg_len field for further
>> input sanitization. If the client only supplies 1-3 bytes of data in
>> sk_buff, then nlh->nlmsg_len remains partially uninitialized and
>> contains leftover memory from the corresponding kernel allocation.
>> Operating on such data may result in indeterminate evaluation of the
>> nlmsg_len < sizeof(*nlh) expression.
>>
>> The bug was discovered by a runtime instrumentation designed to detect
>> use of uninitialized memory in the kernel. The patch prevents this and
>> other similar tools (e.g. KMSAN) from flagging this behavior in the future.
>
> Instead of changing all the internal users wouldn't it be better
> to add this check once in netlink_unicast_kernel?
>

Perhaps. I must admit I'm not very familiar with this code
area/interface, so I preferred to fix the few specific cases instead
of submitting a general patch, which might have some unexpected side
effects, e.g. behavior different from one of the internal clients etc.

If you think one check in netlink_unicast_kernel is a better way to do
it, I'm happy to implement it like that.

Thanks,
Mateusz

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] decnet: dn_rtmsg: Improve input length sanitization in dnrmg_receive_user_skb Mateusz Jurczyk <mjurczyk@google.com> - 2017-06-07 15:20 +0200
  Re: [PATCH v2] decnet: dn_rtmsg: Improve input length sanitization  in dnrmg_receive_user_skb Florian Westphal <fw@strlen.de> - 2017-06-07 16:20 +0200
    Re: [PATCH v2] decnet: dn_rtmsg: Improve input length sanitization in dnrmg_receive_user_skb Mateusz Jurczyk <mjurczyk@google.com> - 2017-06-07 16:50 +0200
      Re: [PATCH v2] decnet: dn_rtmsg: Improve input length sanitization  in dnrmg_receive_user_skb David Miller <davem@davemloft.net> - 2017-06-08 16:40 +0200
  [PATCH v2] decnet: dn_rtmsg: Improve input length sanitization in dnrmg_receive_user_skb Mateusz Jurczyk <mjurczyk@google.com> - 2017-06-07 16:20 +0200

csiph-web