Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1659694

[PATCH v2 1/1] PCI: imx6: Add pcie compliance test option

Show all headers | View raw

Link speed must not be limited to gen1 during link test for compliance
tests

Signed-off-by: Stefan Schoefegger <stefan.schoefegger@ginzinger.com>
---

Changes since v1:
 - pci-imx6.c moved to dwc directory

 drivers/pci/dwc/Kconfig    | 10 ++++++++++
 drivers/pci/dwc/pci-imx6.c | 21 ++++++++++++---------
 2 files changed, 22 insertions(+), 9 deletions(-)

diff --git a/drivers/pci/dwc/Kconfig b/drivers/pci/dwc/Kconfig
index b7e15526d676..b6e9ced5a45d 100644
--- a/drivers/pci/dwc/Kconfig
+++ b/drivers/pci/dwc/Kconfig
@@ -77,6 +77,16 @@ config PCI_IMX6
 	select PCIEPORTBUS
 	select PCIE_DW_HOST
 
+config PCI_IMX6_COMPLIANCE_TEST
+	bool "Enable pcie compliance tests on imx6"
+	depends on PCI_IMX6
+	default n
+	help
+	  Enables support for pcie compliance test on FSL iMX SoCs.
+	  The link speed wouldn't be limited to gen1 when enabled.
+	  Enable only during compliance tests, otherwise
+	  link detection will fail on some peripherals.
+
 config PCIE_SPEAR13XX
 	bool "STMicroelectronics SPEAr PCIe controller"
 	depends on PCI
diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c
index 19a289b8cc94..b0fbe52e25b0 100644
--- a/drivers/pci/dwc/pci-imx6.c
+++ b/drivers/pci/dwc/pci-imx6.c
@@ -533,15 +533,18 @@ static int imx6_pcie_establish_link(struct imx6_pcie *imx6_pcie)
 	u32 tmp;
 	int ret;
 
-	/*
-	 * Force Gen1 operation when starting the link.  In case the link is
-	 * started in Gen2 mode, there is a possibility the devices on the
-	 * bus will not be detected at all.  This happens with PCIe switches.
-	 */
-	tmp = dw_pcie_readl_dbi(pci, PCIE_RC_LCR);
-	tmp &= ~PCIE_RC_LCR_MAX_LINK_SPEEDS_MASK;
-	tmp |= PCIE_RC_LCR_MAX_LINK_SPEEDS_GEN1;
-	dw_pcie_writel_dbi(pci, PCIE_RC_LCR, tmp);
+	if (!IS_ENABLED(CONFIG_PCI_IMX6_COMPLIANCE_TEST)) {
+		/*
+		 * Force Gen1 operation when starting the link.  In case the
+		 * link is started in Gen2 mode, there is a possibility the
+		 * devices on the bus will not be detected at all.  This
+		 * happens with PCIe switches.
+		 */
+		tmp = dw_pcie_readl_dbi(pci, PCIE_RC_LCR);
+		tmp &= ~PCIE_RC_LCR_MAX_LINK_SPEEDS_MASK;
+		tmp |= PCIE_RC_LCR_MAX_LINK_SPEEDS_GEN1;
+		dw_pcie_writel_dbi(pci, PCIE_RC_LCR, tmp);
+	}
 
 	/* Start LTSSM. */
 	if (imx6_pcie->variant == IMX7D)
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/1] PCI: imx6: Add pcie compliance test option Stefan Schoefegger <stefan.schoefegger@ginzinger.com> - 2017-06-07 13:40 +0200
  Re: [PATCH v2 1/1] PCI: imx6: Add pcie compliance test option Bjorn Helgaas <helgaas@kernel.org> - 2017-06-13 01:50 +0200
    RE: [PATCH v2 1/1] PCI: imx6: Add pcie compliance test option Richard Zhu <hongxing.zhu@nxp.com> - 2017-06-13 04:10 +0200
      Re: [PATCH v2 1/1] PCI: imx6: Add pcie compliance test option Schöfegger Stefan          <Stefan.Schoefegger@ginzinger.com> - 2017-06-13 08:00 +0200
    Re: [PATCH v2 1/1] PCI: imx6: Add pcie compliance test option Schöfegger Stefan          <Stefan.Schoefegger@ginzinger.com> - 2017-06-13 07:50 +0200
      Re: [PATCH v2 1/1] PCI: imx6: Add pcie compliance test option Bjorn Helgaas <helgaas@kernel.org> - 2017-06-13 16:00 +0200
        Re: [PATCH v2 1/1] PCI: imx6: Add pcie compliance test option Schöfegger Stefan          <Stefan.Schoefegger@ginzinger.com> - 2017-06-14 08:00 +0200
          Re: [PATCH v2 1/1] PCI: imx6: Add pcie compliance test option Fabio Estevam <festevam@gmail.com> - 2017-06-14 21:20 +0200
            Re: [PATCH v2 1/1] PCI: imx6: Add pcie compliance test option Schöfegger Stefan          <Stefan.Schoefegger@ginzinger.com> - 2017-06-19 08:50 +0200

csiph-web