Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1659668
| From | "Kirill A. Shutemov" <kirill@shutemov.name> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] x86/mm/hotplug: fix BUG_ON() after hotremove |
| Date | 2017-06-07 12:50 +0200 |
| Message-ID | <tPGHf-5ui-9@gated-at.bofh.it> (permalink) |
| References | <tPqCu-3oY-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Jun 06, 2017 at 01:35:12PM -0400, Jérôme Glisse wrote: > With commit af2cf278ef4f we no longer free pud so that we > do not have synchronize all pgd on hotremove/vfree. But the > new 5 level page table code re-added that code f2a6a705 and > thus we now trigger a BUG_ON() l128 in sync_global_pgds() > > This patch remove free_pud() like in af2cf278ef4f Good catch. Thanks! But I think we only need to skip free_pud_table() for 4-level paging. If we don't we would leave 513 page tables around instead of one in 5-level paging case. I don't think it's acceptable. And please use patch subject lines along with commit hashes to simplify reading commit message. -- Kirill A. Shutemov
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] x86/mm/hotplug: fix BUG_ON() after hotremove Jérôme Glisse <jglisse@redhat.com> - 2017-06-06 19:40 +0200
Re: [PATCH] x86/mm/hotplug: fix BUG_ON() after hotremove Logan Gunthorpe <logang@deltatee.com> - 2017-06-06 22:00 +0200
Re: [PATCH] x86/mm/hotplug: fix BUG_ON() after hotremove "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-06-07 12:50 +0200
Re: [PATCH] x86/mm/hotplug: fix BUG_ON() after hotremove Jerome Glisse <jglisse@redhat.com> - 2017-06-07 17:10 +0200
csiph-web